Re: [Qemu-devel] [PATCH] usb:xhci:fix memory leak in usb_xhci_exit

2016-09-13 Thread Gerd Hoffmann 
On Di, 2016-09-13 at 05:22 +, 李强 wrote:
> If the xhci uses msix, it doesn't free the corresponding
> 
> memory, thus leading a memory leak issue. This patch avoid this.

Patch looks good but is corrupted:

Applying: usb:xhci:fix memory leak in usb_xhci_exit
fatal: corrupt patch at line 19

Please send patches using "git send-email" to avoid this.

thanks,
  Gerd

[Qemu-devel] [PATCH] usb:xhci:fix memory leak in usb_xhci_exit

2016-09-12 Thread 李强 
If the xhci uses msix, it doesn't free the corresponding
memory, thus leading a memory leak issue. This patch avoid this.

Signed-off-by: Li Qiang 
---
hw/usb/hcd-xhci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 188f954..281a2a5 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -3709,8 +3709,7 @@ static void usb_xhci_exit(PCIDevice *dev)
 /* destroy msix memory region */
 if (dev->msix_table && dev->msix_pba
 && dev->msix_entry_used) {
-memory_region_del_subregion(>mem, >msix_table_mmio);
-memory_region_del_subregion(>mem, >msix_pba_mmio);
+msix_uninit(dev, >mem, >mem);
 }
 usb_bus_release(>bus);
--
1.8.3.1