Re: [Qemu-devel] [PATCH] vmdk: Only read cid from image file when opening

2013-10-17 Thread Stefan Hajnoczi
On Fri, Oct 11, 2013 at 03:55:39PM +0800, Fam Zheng wrote: > @@ -378,6 +359,22 @@ static int vmdk_parent_open(BlockDriverState *bs) > } > > pstrcpy(bs->backing_file, end_name - p_name + 1, p_name); > + > +ret = bdrv_open_backing_file(bs, NULL, errp); This breaks 'backin

[Qemu-devel] [PATCH] vmdk: Only read cid from image file when opening

2013-10-11 Thread Fam Zheng
Previously cid of parent is parsed from image file for every IO request. We already have L1/L2 cache and don't have assumption that parent image can be updated behind us, so remove this to get more efficiency. The parent CID is checked them when opening backing file. Signed-off-by: Fam Zheng ---