Re: [Qemu-devel] [PATCH] xen_disk: fix io accounting

2014-02-07 Thread Stefano Stabellini
On Thu, 6 Feb 2014, Andreas Färber wrote: > Am 06.02.2014 16:55, schrieb Olaf Hering: > > bdrv_acct_done was called unconditional. But in case the ioreq has no > > segments there is no matching bdrv_acct_start call. This could lead to > > bogus accounting values. > > > > Found by code inspection.

Re: [Qemu-devel] [PATCH] xen_disk: fix io accounting

2014-02-06 Thread Andreas Färber
Am 06.02.2014 16:55, schrieb Olaf Hering: > bdrv_acct_done was called unconditional. But in case the ioreq has no > segments there is no matching bdrv_acct_start call. This could lead to > bogus accounting values. > > Found by code inspection. > > Signed-off-by: Olaf Hering > --- > hw/block/xen

[Qemu-devel] [PATCH] xen_disk: fix io accounting

2014-02-06 Thread Olaf Hering
bdrv_acct_done was called unconditional. But in case the ioreq has no segments there is no matching bdrv_acct_start call. This could lead to bogus accounting values. Found by code inspection. Signed-off-by: Olaf Hering --- hw/block/xen_disk.c | 13 - 1 file changed, 12 insertions(+)