Re: [Qemu-devel] [PATCH 0/2] vmmouse: convert qdev pointer property to QOM link relationship

2018-03-07 Thread Zihan Yang
Hi Philippe, Thanks for reviewing my patch. Yes I though about it, a specific header file with only several lines seems not worth it, but otherwise I would have to define redundant macro in vmmouse.c. Currently rebundant macro is ok but if we need some more macros, we would end on creating a spec

Re: [Qemu-devel] [PATCH 0/2] vmmouse: convert qdev pointer property to QOM link relationship

2018-03-07 Thread Philippe Mathieu-Daudé
Hi Zihan Yang, On 03/07/2018 01:55 PM, Zihan Yang wrote: > Hi all, this is a bitesized patch from me a while ago, it seems a little > old but I wonder if there is any opinion about it? Is it still valid? For a single TYPE use, I'm not sure use a specific header is useful (patch #1). The 2nd patc

Re: [Qemu-devel] [PATCH 0/2] vmmouse: convert qdev pointer property to QOM link relationship

2018-03-07 Thread Zihan Yang
Hi all, this is a bitesized patch from me a while ago, it seems a little old but I wonder if there is any opinion about it? Is it still valid? Thanks. 2018-02-04 15:28 GMT+08:00 Zihan Yang : > The ps2_mouse property of vmmouse is still pointer type which > is defined by DEFINE_PROP_PTR. But qde

[Qemu-devel] [PATCH 0/2] vmmouse: convert qdev pointer property to QOM link relationship

2018-02-03 Thread Zihan Yang
The ps2_mouse property of vmmouse is still pointer type which is defined by DEFINE_PROP_PTR. But qdev pointer property should be avoided according to qdev-properties.h. Convert it to QOM link relationship. It involves two patches because it requires the TYPE_I8042 macro which is defined in anothe