Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-12-10 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: I understand why you're adding this but this is one of those horrible abuses of qdev that we really need to avoid. There are two valid reasons why hotplug is not possible: 1) Hotplugging is not supported by the *slot*. This is something that needs

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-12-10 Thread Gerd Hoffmann
Hi, Wrong. PCI certainly isn't the only bus which supports hotplug. It *does* make sense to handle generic hotplug stuff at qdev level. Could the proper place be qbus instead of qdev? No. But PCI is the only bus where some devices are hot-pluggable and some are not. On all other

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-22 Thread Gerd Hoffmann
I understand why you're adding this but this is one of those horrible abuses of qdev that we really need to avoid. There are two valid reasons why hotplug is not possible: 1) Hotplugging is not supported by the *slot*. This is something that needs to be exposes through ACPI. This is not a qdev

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-22 Thread Gleb Natapov
On Mon, Nov 22, 2010 at 11:17:10AM +0100, Gerd Hoffmann wrote: An ideal interface would explicitly allow a user to mark a series of PCI slots as no supporting hotplug. It would be convenient in order to ensure that your virtio-net wasn't accidentally ejected by a click-happy Windows user.

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-20 Thread Anthony Liguori
On 11/18/2010 04:45 AM, Gerd Hoffmann wrote: Hi, This patch series adds a qdev flag which allows devices being tagged as not hotpluggable. It also sets this flag for a number of devices. I understand why you're adding this but this is one of those horrible abuses of qdev that we

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-20 Thread Gleb Natapov
On Fri, Nov 19, 2010 at 08:30:35PM -0600, Anthony Liguori wrote: On 11/18/2010 04:45 AM, Gerd Hoffmann wrote: Hi, This patch series adds a qdev flag which allows devices being tagged as not hotpluggable. It also sets this flag for a number of devices. I understand why you're adding

[Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-18 Thread Gerd Hoffmann
Hi, This patch series adds a qdev flag which allows devices being tagged as not hotpluggable. It also sets this flag for a number of devices. Gerd Hoffmann (3): qdev: allow devices being tagged as not hotpluggable. piix: tag as non-hotpluggable. vga: tag as not hotplugable.

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote: Hi, This patch series adds a qdev flag which allows devices being tagged as not hotpluggable. It also sets this flag for a number of devices. Do we want to be able to mark device as not hot-unpluggable from command like too?

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-18 Thread Gerd Hoffmann
On 11/18/10 12:01, Gleb Natapov wrote: On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote: Hi, This patch series adds a qdev flag which allows devices being tagged as not hotpluggable. It also sets this flag for a number of devices. Do we want to be able to mark device as not

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 12:13:21PM +0100, Gerd Hoffmann wrote: On 11/18/10 12:01, Gleb Natapov wrote: On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote: Hi, This patch series adds a qdev flag which allows devices being tagged as not hotpluggable. It also sets this flag for a

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-18 Thread Gerd Hoffmann
On 11/18/10 12:20, Gleb Natapov wrote: On Thu, Nov 18, 2010 at 12:13:21PM +0100, Gerd Hoffmann wrote: On 11/18/10 12:01, Gleb Natapov wrote: On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote: Hi, This patch series adds a qdev flag which allows devices being tagged as not

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 12:29:07PM +0100, Gerd Hoffmann wrote: On 11/18/10 12:20, Gleb Natapov wrote: On Thu, Nov 18, 2010 at 12:13:21PM +0100, Gerd Hoffmann wrote: On 11/18/10 12:01, Gleb Natapov wrote: On Thu, Nov 18, 2010 at 11:45:15AM +0100, Gerd Hoffmann wrote: Hi, This patch

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-18 Thread Michael Tokarev
On 18.11.2010 14:42, Gleb Natapov wrote: [] For *that* use case well have to do a bit more like dynamically building the acpi table which indicates which slots are hot-pluggable and which are not. Which indeed would be useful and would fix the windows xp offering me to unplug the piix chipset

Re: [Qemu-devel] [PATCH 0/3] add hotplug opt-out option for devices.

2010-11-18 Thread Gleb Natapov
On Thu, Nov 18, 2010 at 03:07:48PM +0300, Michael Tokarev wrote: On 18.11.2010 14:42, Gleb Natapov wrote: [] For *that* use case well have to do a bit more like dynamically building the acpi table which indicates which slots are hot-pluggable and which are not. Which indeed would be