Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures

2019-08-18 Thread Jason Wang
On 2019/8/19 上午5:38, Philippe Mathieu-Daudé wrote: > Hi Jason, > > On 8/8/19 4:34 PM, Philippe Mathieu-Daudé wrote: >> This is a preparatory cleanup series. >> >> Commit 75020a70215 introduced 4 very equivalent structures: >> - tcp_header and tcp_hdr, >> - udp_header and udp_hdr. >> >> Choose the

Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures

2019-08-18 Thread Philippe Mathieu-Daudé
Hi Jason, On 8/8/19 4:34 PM, Philippe Mathieu-Daudé wrote: > This is a preparatory cleanup series. > > Commit 75020a70215 introduced 4 very equivalent structures: > - tcp_header and tcp_hdr, > - udp_header and udp_hdr. > > Choose the most widely use in the codebase, which happens to > provide co

Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures

2019-08-12 Thread Dmitry Fleytman
Reviewed-by: Dmitry Fleytman > On 8 Aug 2019, at 17:34, Philippe Mathieu-Daudé wrote: > > This is a preparatory cleanup series. > > Commit 75020a70215 introduced 4 very equivalent structures: > - tcp_header and tcp_hdr, > - udp_header and udp_hdr. > > Choose the most widely use in the codebas

[Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures

2019-08-08 Thread Philippe Mathieu-Daudé
This is a preparatory cleanup series. Commit 75020a70215 introduced 4 very equivalent structures: - tcp_header and tcp_hdr, - udp_header and udp_hdr. Choose the most widely use in the codebase, which happens to provide convenient bitfields manipulation macros and is not endian-specific. Philippe