Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-27 Thread Avi Kivity
On 03/26/2012 07:29 PM, Anthony Liguori wrote: On 03/26/2012 10:54 AM, Isaku Yamahata wrote: On Mon, Mar 26, 2012 at 02:20:24PM +0200, Jan Kiszka wrote: I'm also sure we will have to refactor the merge significantly again for the introduction of additional chipsets and PC boards. But unless

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-27 Thread Anthony Liguori
On 03/27/2012 05:31 AM, Avi Kivity wrote: I think the better approach is to have a PCNorthBridge base-class that contains functionality like PAM/SRAM that both I440FX and Q35 inherit from. I hate to transform this into a languagey discussion, but I don't think inheritance is the right thing

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-27 Thread Avi Kivity
On 03/27/2012 03:52 PM, Anthony Liguori wrote: On 03/27/2012 05:31 AM, Avi Kivity wrote: I think the better approach is to have a PCNorthBridge base-class that contains functionality like PAM/SRAM that both I440FX and Q35 inherit from. I hate to transform this into a languagey discussion,

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Jan Kiszka
On 2012-03-26 04:06, Wanpeng Li wrote: From: Anthony Liguori aligu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this series are: 1) Things like -m and -bios-name are now device model properties

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Andreas Färber
Am 26.03.2012 04:06, schrieb Wanpeng Li: From: Anthony Liguori aligu...@us.ibm.com Resending an old cover letter is not a good idea. This looks like a v2, so please mark it as such in the subjects; it's missing a Change Log against Anthony's version. I take it, some patches were dropped? This

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Wanpeng Li
On Mon, Mar 26, 2012 at 02:47:19PM +0200, Andreas Färber wrote: Am 26.03.2012 04:06, schrieb Wanpeng Li: From: Anthony Liguori aligu...@us.ibm.com Resending an old cover letter is not a good idea. This looks like a v2, so please mark it as such in the subjects; it's missing a Change Log against

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Isaku Yamahata
On Mon, Mar 26, 2012 at 02:20:24PM +0200, Jan Kiszka wrote: I'm also sure we will have to refactor the merge significantly again for the introduction of additional chipsets and PC boards. But unless those requirements can already be specified (Isaku?), that might be unavoidable. Agreed. At

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 02:06, Wanpeng Li l...@linux.vnet.ibm.com wrote: From: Anthony Liguori aligu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc.  The highlights of this series are: Please fix coding style while moving.

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 12:20, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-03-26 04:06, Wanpeng Li wrote: From: Anthony Liguori aligu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc.  The highlights of this series are:

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/25/2012 09:06 PM, Wanpeng Li wrote: From: Anthony Liguorialigu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this series are: 1) Things like -m and -bios-name are now device model properties 2)

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 10:54 AM, Isaku Yamahata wrote: On Mon, Mar 26, 2012 at 02:20:24PM +0200, Jan Kiszka wrote: I'm also sure we will have to refactor the merge significantly again for the introduction of additional chipsets and PC boards. But unless those requirements can already be specified

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 07:20 AM, Jan Kiszka wrote: On 2012-03-26 04:06, Wanpeng Li wrote: From: Anthony Liguorialigu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this series are: 1) Things like -m and

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 12:09 PM, Blue Swirl wrote: On Mon, Mar 26, 2012 at 02:06, Wanpeng Lil...@linux.vnet.ibm.com wrote: From: Anthony Liguorialigu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this series

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 17:35, Anthony Liguori anth...@codemonkey.ws wrote: On 03/26/2012 12:09 PM, Blue Swirl wrote: On Mon, Mar 26, 2012 at 02:06, Wanpeng Lil...@linux.vnet.ibm.com  wrote: From: Anthony Liguorialigu...@us.ibm.com This series aggressively refactors the PC machine

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 12:43 PM, Blue Swirl wrote: On Mon, Mar 26, 2012 at 17:35, Anthony Liguorianth...@codemonkey.ws wrote: On 03/26/2012 12:09 PM, Blue Swirl wrote: On Mon, Mar 26, 2012 at 02:06, Wanpeng Lil...@linux.vnet.ibm.comwrote: From: Anthony Liguorialigu...@us.ibm.com This series

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 17:45, Anthony Liguori anth...@codemonkey.ws wrote: On 03/26/2012 12:43 PM, Blue Swirl wrote: On Mon, Mar 26, 2012 at 17:35, Anthony Liguorianth...@codemonkey.ws  wrote: On 03/26/2012 12:09 PM, Blue Swirl wrote: On Mon, Mar 26, 2012 at 02:06, Wanpeng

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 01:01 PM, Blue Swirl wrote: On Mon, Mar 26, 2012 at 17:45, Anthony Liguorianth...@codemonkey.ws wrote: Is this something we universally want to do? What would we do about patches to audio? I'd do it in cases when there is code movement, then git blame will not be very useful

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Blue Swirl
On Mon, Mar 26, 2012 at 18:07, Anthony Liguori anth...@codemonkey.ws wrote: On 03/26/2012 01:01 PM, Blue Swirl wrote: On Mon, Mar 26, 2012 at 17:45, Anthony Liguorianth...@codemonkey.ws  wrote: Is this something we universally want to do?  What would we do about patches to audio? I'd

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Jan Kiszka
On 2012-03-26 19:33, Anthony Liguori wrote: On 03/26/2012 07:20 AM, Jan Kiszka wrote: On 2012-03-26 04:06, Wanpeng Li wrote: From: Anthony Liguorialigu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 02:30 PM, Jan Kiszka wrote: On 2012-03-26 19:33, Anthony Liguori wrote: On 03/26/2012 07:20 AM, Jan Kiszka wrote: On 2012-03-26 04:06, Wanpeng Li wrote: From: Anthony Liguorialigu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Jan Kiszka
On 2012-03-26 21:35, Anthony Liguori wrote: On 03/26/2012 02:30 PM, Jan Kiszka wrote: On 2012-03-26 19:33, Anthony Liguori wrote: On 03/26/2012 07:20 AM, Jan Kiszka wrote: On 2012-03-26 04:06, Wanpeng Li wrote: From: Anthony Liguorialigu...@us.ibm.com This series aggressively refactors the

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 02:37 PM, Jan Kiszka wrote: On 2012-03-26 21:35, Anthony Liguori wrote: Since this is an easily refactorable thing to look at later, I think we should start with extracting the types. My worry is that those three refactorings set bad examples for others. So I'd like to avoid

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Jan Kiszka
On 2012-03-26 21:39, Anthony Liguori wrote: On 03/26/2012 02:37 PM, Jan Kiszka wrote: On 2012-03-26 21:35, Anthony Liguori wrote: Since this is an easily refactorable thing to look at later, I think we should start with extracting the types. My worry is that those three refactorings set bad

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 02:44 PM, Jan Kiszka wrote: On 2012-03-26 21:39, Anthony Liguori wrote: On 03/26/2012 02:37 PM, Jan Kiszka wrote: On 2012-03-26 21:35, Anthony Liguori wrote: Since this is an easily refactorable thing to look at later, I think we should start with extracting the types. My

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 02:44 PM, Jan Kiszka wrote: On 2012-03-26 21:39, Anthony Liguori wrote: On 03/26/2012 02:37 PM, Jan Kiszka wrote: On 2012-03-26 21:35, Anthony Liguori wrote: Since this is an easily refactorable thing to look at later, I think we should start with extracting the types. My

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Jan Kiszka
On 2012-03-26 21:49, Anthony Liguori wrote: On 03/26/2012 02:44 PM, Jan Kiszka wrote: On 2012-03-26 21:39, Anthony Liguori wrote: On 03/26/2012 02:37 PM, Jan Kiszka wrote: On 2012-03-26 21:35, Anthony Liguori wrote: Since this is an easily refactorable thing to look at later, I think we

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 03:10 PM, Jan Kiszka wrote: On 2012-03-26 21:49, Anthony Liguori wrote: On 03/26/2012 02:44 PM, Jan Kiszka wrote: This would also mean that reference counting should be revisited although with how dereferencing a parent affects the child. It's not rocket science, but it's also

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Jan Kiszka
On 2012-03-26 22:13, Anthony Liguori wrote: On 03/26/2012 03:10 PM, Jan Kiszka wrote: On 2012-03-26 21:49, Anthony Liguori wrote: On 03/26/2012 02:44 PM, Jan Kiszka wrote: This would also mean that reference counting should be revisited although with how dereferencing a parent affects the

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Anthony Liguori
On 03/26/2012 03:30 PM, Jan Kiszka wrote: On 2012-03-26 22:13, Anthony Liguori wrote: On 03/26/2012 03:10 PM, Jan Kiszka wrote: On 2012-03-26 21:49, Anthony Liguori wrote: On 03/26/2012 02:44 PM, Jan Kiszka wrote: This would also mean that reference counting should be revisited although with

[Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-25 Thread Wanpeng Li
From: Anthony Liguori aligu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this series are: 1) Things like -m and -bios-name are now device model properties 2) The i440fx and piix3 are now modelled in a