Re: [Qemu-devel] [PATCH 0/7] Add checks for corruption in the snapshot table

2018-03-06 Thread Alberto Garcia
On Tue 06 Mar 2018 03:06:46 PM CET, Kevin Wolf wrote: >> So although having a way to repair this kind of corruption would be >> nice, we should still allow the user to try to open the image and >> read data from it without requiring a potentially destructive >> operation first. > > Generally

Re: [Qemu-devel] [PATCH 0/7] Add checks for corruption in the snapshot table

2018-03-06 Thread Kevin Wolf
Am 01.03.2018 um 17:27 hat Alberto Garcia geschrieben: > Hey ho! > > As we have already discussed in the mailing list, the offset and size > values of snapshots' L1 tables are almost never validated in the QEMU > code. > > One way to deal with this is to validate them when the image is being >

[Qemu-devel] [PATCH 0/7] Add checks for corruption in the snapshot table

2018-03-01 Thread Alberto Garcia
Hey ho! As we have already discussed in the mailing list, the offset and size values of snapshots' L1 tables are almost never validated in the QEMU code. One way to deal with this is to validate them when the image is being opened (in qcow2_read_snapshots()) and return an error if there's