Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Igor Mammedov
On Wed, 18 Dec 2013 16:59:02 +0100 Paolo Bonzini wrote: > Il 18/12/2013 16:48, Igor Mammedov ha scritto: > >> Hotplugging a device is a special case of plugging a device. If a bus > >> or device only supports cold-plug, that can be done using > >> "bc->allow_hotplug = false" or "dc->hotpluggable

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Igor Mammedov
On Wed, 18 Dec 2013 18:26:07 +0200 "Michael S. Tsirkin" wrote: > On Wed, Dec 18, 2013 at 04:48:09PM +0100, Igor Mammedov wrote: > > On Wed, 18 Dec 2013 11:36:52 +0100 > > Paolo Bonzini wrote: > > > > > Il 17/12/2013 20:38, Anthony Liguori ha scritto: > > > > On Tue, Dec 17, 2013 at 4:38 AM, Pao

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Michael S. Tsirkin
On Wed, Dec 18, 2013 at 04:48:09PM +0100, Igor Mammedov wrote: > On Wed, 18 Dec 2013 11:36:52 +0100 > Paolo Bonzini wrote: > > > Il 17/12/2013 20:38, Anthony Liguori ha scritto: > > > On Tue, Dec 17, 2013 at 4:38 AM, Paolo Bonzini > > > wrote: > > >> Il 17/12/2013 00:26, Anthony Liguori ha scri

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Paolo Bonzini
Il 18/12/2013 16:48, Igor Mammedov ha scritto: >> Hotplugging a device is a special case of plugging a device. If a bus >> or device only supports cold-plug, that can be done using >> "bc->allow_hotplug = false" or "dc->hotpluggable = false". > Do we need per instance ability to set "hotpluggable"

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Igor Mammedov
On Wed, 18 Dec 2013 11:36:52 +0100 Paolo Bonzini wrote: > Il 17/12/2013 20:38, Anthony Liguori ha scritto: > > On Tue, Dec 17, 2013 at 4:38 AM, Paolo Bonzini wrote: > >> Il 17/12/2013 00:26, Anthony Liguori ha scritto: > >>> Sharing hot plug code is a good thing. Making hotplug a qdev-level > >

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-18 Thread Paolo Bonzini
Il 17/12/2013 20:38, Anthony Liguori ha scritto: > On Tue, Dec 17, 2013 at 4:38 AM, Paolo Bonzini wrote: >> Il 17/12/2013 00:26, Anthony Liguori ha scritto: >>> Sharing hot plug code is a good thing. Making hotplug a qdev-level >>> concept seems like a bad thing to me. >> >> Can you explain what

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-17 Thread Anthony Liguori
On Tue, Dec 17, 2013 at 4:38 AM, Paolo Bonzini wrote: > Il 17/12/2013 00:26, Anthony Liguori ha scritto: >> Sharing hot plug code is a good thing. Making hotplug a qdev-level >> concept seems like a bad thing to me. > > Can you explain what you mean? The question is whether "hotpluggable" as a p

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-17 Thread Paolo Bonzini
Il 17/12/2013 00:26, Anthony Liguori ha scritto: > Sharing hot plug code is a good thing. Making hotplug a qdev-level > concept seems like a bad thing to me. Can you explain what you mean? > The series is a net add of code so I don't think we're winning anything > by generalizing here. Any gene

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-17 Thread Igor Mammedov
On Mon, 16 Dec 2013 15:26:37 -0800 Anthony Liguori wrote: > Igor Mammedov writes: > > > changes since v2: > > * s/hotplugable/hotpluggable/ > > * move hotplug check to an earlier patch: > > "qdev: add "hotpluggable" property to Device" > > -- > > Refactor PCI specific hotplug API to a more ge

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-16 Thread Peter Crosthwaite
On Tue, Dec 17, 2013 at 9:26 AM, Anthony Liguori wrote: > Igor Mammedov writes: > >> changes since v2: >> * s/hotplugable/hotpluggable/ >> * move hotplug check to an earlier patch: >> "qdev: add "hotpluggable" property to Device" >> -- >> Refactor PCI specific hotplug API to a more generic/reus

Re: [Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-16 Thread Anthony Liguori
Igor Mammedov writes: > changes since v2: > * s/hotplugable/hotpluggable/ > * move hotplug check to an earlier patch: > "qdev: add "hotpluggable" property to Device" > -- > Refactor PCI specific hotplug API to a more generic/reusable one. > Model it after SCSI-BUS like hotplug API replacing sin

[Qemu-devel] [PATCH 00/11 v3] Refactor PCI/SHPC/PCIE hotplug to use a more generic hotplug API

2013-12-13 Thread Igor Mammedov
changes since v2: * s/hotplugable/hotpluggable/ * move hotplug check to an earlier patch: "qdev: add "hotpluggable" property to Device" -- Refactor PCI specific hotplug API to a more generic/reusable one. Model it after SCSI-BUS like hotplug API replacing single hotplug callback with hotplug/hot_