Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-07 Thread Richard Henderson
On 02/06/2014 11:26 AM, Lluís Vilanova wrote: At which point, option 2 would be the best bet, I think. Right. For the 3rd option I was also thinking about having per-vCPU tracing states (in the case of guest events), so that you can trace separate events depending on the vCPU. Which

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-07 Thread Peter Maydell
On 7 February 2014 14:49, Richard Henderson r...@twiddle.net wrote: On 02/06/2014 11:26 AM, Lluís Vilanova wrote: At which point, option 2 would be the best bet, I think. Right. For the 3rd option I was also thinking about having per-vCPU tracing states (in the case of guest events), so that

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-07 Thread Lluís Vilanova
Peter Maydell writes: On 7 February 2014 14:49, Richard Henderson r...@twiddle.net wrote: On 02/06/2014 11:26 AM, Lluís Vilanova wrote: At which point, option 2 would be the best bet, I think. Right. For the 3rd option I was also thinking about having per-vCPU tracing states (in the case of

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-06 Thread Richard Henderson
On 02/04/2014 12:33 PM, Lluís Vilanova wrote: Richard Henderson writes: On 01/31/2014 08:09 AM, Lluís Vilanova wrote: Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event propery). Such events

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-06 Thread Lluís Vilanova
Richard Henderson writes: On 02/04/2014 12:33 PM, Lluís Vilanova wrote: Richard Henderson writes: On 01/31/2014 08:09 AM, Lluís Vilanova wrote: Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Peter Maydell
On 4 February 2014 14:57, Richard Henderson r...@twiddle.net wrote: I suppose I have no major objection to the feature, although frankly it's not especially exciting. I can't really imagine ever wanting to bulk trace all of the helpers. Tracing specific helpers on a target-by-target basis,

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Richard Henderson
On 01/31/2014 08:09 AM, Lluís Vilanova wrote: Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event propery). Such events generate an extra set of tracing functions that can be called during TCG

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Richard Henderson
On 02/04/2014 07:02 AM, Peter Maydell wrote: On 4 February 2014 14:57, Richard Henderson r...@twiddle.net wrote: I suppose I have no major objection to the feature, although frankly it's not especially exciting. I can't really imagine ever wanting to bulk trace all of the helpers. Tracing

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Lluís Vilanova
Richard Henderson writes: On 01/31/2014 08:09 AM, Lluís Vilanova wrote: Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event propery). Such events generate an extra set of tracing functions that can

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Lluís Vilanova
Peter Maydell writes: On 4 February 2014 14:57, Richard Henderson r...@twiddle.net wrote: I suppose I have no major objection to the feature, although frankly it's not especially exciting. I can't really imagine ever wanting to bulk trace all of the helpers. Tracing specific helpers on a

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-04 Thread Lluís Vilanova
Richard Henderson writes: On 02/04/2014 07:02 AM, Peter Maydell wrote: On 4 February 2014 14:57, Richard Henderson r...@twiddle.net wrote: I suppose I have no major objection to the feature, although frankly it's not especially exciting. I can't really imagine ever wanting to bulk trace all

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-03 Thread Stefan Hajnoczi
On Fri, Jan 31, 2014 at 05:09:03PM +0100, Lluís Vilanova wrote: Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event propery). Such events generate an extra set of tracing functions that can be called

Re: [Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-02-03 Thread Lluís Vilanova
Stefan Hajnoczi writes: On Fri, Jan 31, 2014 at 05:09:03PM +0100, Lluís Vilanova wrote: Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event propery). Such events generate an extra set of tracing

[Qemu-devel] [PATCH 00/12] trace: [tcg] Allow tracing guest events in TCG-generated code

2014-01-31 Thread Lluís Vilanova
Adds the base ability to specify which events in the trace-events file may be used to trace guest activity in the TCG code (using the tcg event propery). Such events generate an extra set of tracing functions that can be called during TCG code generation and will automatically redirect a call to