Re: [Qemu-devel] [PATCH 01/21] target-s390x: fix style

2012-09-08 Thread Blue Swirl
On Thu, Sep 6, 2012 at 6:33 PM, Alexander Graf ag...@suse.de wrote: On 02.09.2012, at 13:33, Blue Swirl wrote: Before splitting op_helper.c and helper.c in the next patches, fix style issues. No functional changes. Replace also GCC specific __FUNCTION__ with standard __func__. Don't init

Re: [Qemu-devel] [PATCH 01/21] target-s390x: fix style

2012-09-06 Thread Alexander Graf
On 02.09.2012, at 13:33, Blue Swirl wrote: Before splitting op_helper.c and helper.c in the next patches, fix style issues. No functional changes. Replace also GCC specific __FUNCTION__ with standard __func__. Don't init static variable (cpu_s390x_init:inited) with 0. Signed-off-by:

Re: [Qemu-devel] [PATCH 01/21] target-s390x: fix style

2012-09-04 Thread Richard Henderson
On 2012-09-03 12:10, Blue Swirl wrote: I missed that one. He's rewriting translate.c, while I'm mostly touching op_helper.c. I'd expect it would be simpler for Richard to rebase on my series, because they only change helper calls but don't otherwise touch code. His series rearranges the code

Re: [Qemu-devel] [PATCH 01/21] target-s390x: fix style

2012-09-03 Thread Alexander Graf
On 03.09.2012, at 15:10, Blue Swirl blauwir...@gmail.com wrote: On Mon, Sep 3, 2012 at 4:31 AM, Alexander Graf ag...@suse.de wrote: On 02.09.2012, at 13:33, Blue Swirl wrote: Before splitting op_helper.c and helper.c in the next patches, fix style issues. No functional changes.