Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-25 Thread Peter Maydell
On 17 September 2014 16:22, Richard Henderson r...@twiddle.net wrote: On 09/17/2014 04:54 AM, Andreas Färber wrote: I am fine with adding such hooks, but please let's use a better, active name. CPUClass is the struct name and cpu-exec is a file name; the hook should say what it's doing, not

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Andreas Färber
Am 13.09.2014 um 18:45 schrieb Richard Henderson: In preparation for removing a bunch of ifdefs from cpu_exec. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Richard Henderson r...@twiddle.net --- cpu-exec.c| 9 ++--- include/qom/cpu.h | 5 + qom/cpu.c | 6

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-17 Thread Richard Henderson
On 09/17/2014 04:54 AM, Andreas Färber wrote: I am fine with adding such hooks, but please let's use a better, active name. CPUClass is the struct name and cpu-exec is a file name; the hook should say what it's doing, not where the code (used to) live(s). Just exec_enter/exec_exit possibly?

Re: [Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-14 Thread Alex Bennée
Richard Henderson writes: In preparation for removing a bunch of ifdefs from cpu_exec. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Richard Henderson r...@twiddle.net --- cpu-exec.c| 9 ++--- include/qom/cpu.h | 5 + qom/cpu.c | 6 -- 3 files changed,

[Qemu-devel] [PATCH 01/23] qom: Add cpu_exec_enter and cpu_exec_exit hooks

2014-09-13 Thread Richard Henderson
In preparation for removing a bunch of ifdefs from cpu_exec. Cc: Andreas Färber afaer...@suse.de Signed-off-by: Richard Henderson r...@twiddle.net --- cpu-exec.c| 9 ++--- include/qom/cpu.h | 5 + qom/cpu.c | 6 -- 3 files changed, 11 insertions(+), 9 deletions(-)