Re: [Qemu-devel] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands

2016-12-07 Thread Fam Zheng
On Fri, 12/02 01:52, Max Reitz wrote: > > diff --git a/qemu-img.c b/qemu-img.c > > index afcd51f..b2f4077 100644 > > --- a/qemu-img.c > > +++ b/qemu-img.c > > @@ -679,6 +679,10 @@ static int img_check(int argc, char **argv) > > break; > > } > > } > > + > > +if (!(flag

Re: [Qemu-devel] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands

2016-12-01 Thread Max Reitz
On 31.10.2016 16:38, Fam Zheng wrote: > Checking the status of an image when it is being used by guest is > usually useful, True for qemu-img info and maybe even qemu-img compare (and qemu-img map is just a debugging tool, so that's fine, too), but I don't think qemu-img check is very useful. You'

[Qemu-devel] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands

2016-10-31 Thread Fam Zheng
Checking the status of an image when it is being used by guest is usually useful, and there is no risk of corrupting data, so don't let the upcoming image locking feature limit this use case. Signed-off-by: Fam Zheng --- qemu-img.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)