Re: [Qemu-devel] [PATCH 04/19] block: Don't manually poll in bdrv_drain_all()

2018-04-11 Thread Eric Blake
On 04/11/2018 11:39 AM, Kevin Wolf wrote: > All involved nodes are already idle, we called bdrv_do_draine_begin() on s/draine/drain/ > them. > > The comment in the code suggested that this were not correct because the s/were/was/ > completion of a request on one node could spawn a new request

[Qemu-devel] [PATCH 04/19] block: Don't manually poll in bdrv_drain_all()

2018-04-11 Thread Kevin Wolf
All involved nodes are already idle, we called bdrv_do_draine_begin() on them. The comment in the code suggested that this were not correct because the completion of a request on one node could spawn a new request on a different node (which might have been drained before, so we wouldn't drain the