[Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul

2017-07-04 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Signed-off-by: Paolo Bonzini --- accel/tcg/tcg-all.c| 2 +- include/sysemu/accel.h | 2 +- vl.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/accel/tcg/tcg-all.c

Re: [Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul

2017-07-04 Thread Paolo Bonzini
On 03/07/2017 21:46, Richard Henderson wrote: > On 07/03/2017 09:34 AM, Paolo Bonzini wrote: >> -extern int tcg_tb_size; >> +extern unsigned long tcg_tb_size; > > size_t would be more natural. > > I don't think we support any hosts for which sizeof(size_t) != > sizeof(unsigned long), but

Re: [Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul

2017-07-04 Thread Daniel P. Berrange
On Mon, Jul 03, 2017 at 12:46:06PM -0700, Richard Henderson wrote: > On 07/03/2017 09:34 AM, Paolo Bonzini wrote: > > -extern int tcg_tb_size; > > +extern unsigned long tcg_tb_size; > > size_t would be more natural. > > I don't think we support any hosts for which sizeof(size_t) != >

Re: [Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul

2017-07-03 Thread Richard Henderson
On 07/03/2017 09:34 AM, Paolo Bonzini wrote: -extern int tcg_tb_size; +extern unsigned long tcg_tb_size; size_t would be more natural. I don't think we support any hosts for which sizeof(size_t) != sizeof(unsigned long), but perhaps unsigned lomg tmp; if

[Qemu-devel] [PATCH 04/22] vl: convert -tb-size to qemu_strtoul

2017-07-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- accel/tcg/tcg-all.c| 2 +- include/sysemu/accel.h | 2 +- vl.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index dba9931..e327d90 100644 ---