Re: [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

2013-02-11 Thread Richard Henderson
On 2013-02-10 10:30, Richard Henderson wrote: Signed-off-by: Richard Hendersonr...@twiddle.net --- linux-user/main.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) n32/n64 have different argument registers from o32. In addition, use abi_long properly

Re: [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

2013-02-11 Thread Peter Maydell
On 10 February 2013 18:30, Richard Henderson r...@twiddle.net wrote: Signed-off-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org -if ((unsigned int)ret = (unsigned int)(-1133)) { +if ((abi_ulong)ret = (abi_ulong)-1133) {

Re: [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

2013-02-11 Thread Peter Maydell
On 11 February 2013 17:51, Richard Henderson r...@twiddle.net wrote: On 2013-02-11 09:33, Peter Maydell wrote: You're only changing the cast here, so this isn't something you should feel the need to fix in this patch, but do you know what's special about -1133 ? It does correspond to the

Re: [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

2013-02-11 Thread Richard Henderson
On 2013-02-11 09:33, Peter Maydell wrote: You're only changing the cast here, so this isn't something you should feel the need to fix in this patch, but do you know what's special about -1133 ? It does correspond to the kernel code. C.f. EMAXERRNO. r~

[Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

2013-02-10 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- linux-user/main.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 3df8aa2..3a3be70 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -1783,8