Re: [Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit

2013-11-07 Thread Orit Wasserman 

On 11/06/2013 03:04 PM, Juan Quintela wrote:

Signed-off-by: Juan Quintela quint...@redhat.com
---
  cputlb.c   | 2 +-
  include/exec/memory-internal.h | 6 ++
  2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/cputlb.c b/cputlb.c
index fff0afb..72452e5 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -137,7 +137,7 @@ void tlb_protect_code(ram_addr_t ram_addr)
  void tlb_unprotect_code_phys(CPUArchState *env, ram_addr_t ram_addr,
   target_ulong vaddr)
  {
-cpu_physical_memory_set_dirty_flags(ram_addr, CODE_DIRTY_FLAG);
+cpu_physical_memory_set_dirty_flag(ram_addr, CODE_DIRTY_FLAG);
  }

  static bool tlb_is_dirty_ram(CPUTLBEntry *tlbe)
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index c71a5e6..4ebab80 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -76,6 +76,12 @@ static inline void 
cpu_physical_memory_set_dirty_flags(ram_addr_t addr,
  ram_list.phys_dirty[addr  TARGET_PAGE_BITS] |= dirty_flags;
  }

+static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr,
+  int dirty_flag)
+{
+ram_list.phys_dirty[addr  TARGET_PAGE_BITS] |= dirty_flag;
+}
+
  static inline void cpu_physical_memory_set_dirty(ram_addr_t addr)
  {
  cpu_physical_memory_set_dirty_flags(addr, 0xff);



Reviewed-by: Orit Wasserman owass...@redhat.com

[Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit

2013-11-06 Thread Juan Quintela 
Signed-off-by: Juan Quintela quint...@redhat.com
---
 cputlb.c   | 2 +-
 include/exec/memory-internal.h | 6 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/cputlb.c b/cputlb.c
index fff0afb..72452e5 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -137,7 +137,7 @@ void tlb_protect_code(ram_addr_t ram_addr)
 void tlb_unprotect_code_phys(CPUArchState *env, ram_addr_t ram_addr,
  target_ulong vaddr)
 {
-cpu_physical_memory_set_dirty_flags(ram_addr, CODE_DIRTY_FLAG);
+cpu_physical_memory_set_dirty_flag(ram_addr, CODE_DIRTY_FLAG);
 }

 static bool tlb_is_dirty_ram(CPUTLBEntry *tlbe)
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index c71a5e6..4ebab80 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -76,6 +76,12 @@ static inline void 
cpu_physical_memory_set_dirty_flags(ram_addr_t addr,
 ram_list.phys_dirty[addr  TARGET_PAGE_BITS] |= dirty_flags;
 }

+static inline void cpu_physical_memory_set_dirty_flag(ram_addr_t addr,
+  int dirty_flag)
+{
+ram_list.phys_dirty[addr  TARGET_PAGE_BITS] |= dirty_flag;
+}
+
 static inline void cpu_physical_memory_set_dirty(ram_addr_t addr)
 {
 cpu_physical_memory_set_dirty_flags(addr, 0xff);
-- 
1.8.3.1