Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-08 Thread Stefan Hajnoczi
On Wed, May 07, 2014 at 04:09:27PM +0200, Peter Lieven wrote: On 07.05.2014 12:29, Paolo Bonzini wrote: Il 07/05/2014 12:07, Stefan Hajnoczi ha scritto: On Fri, May 02, 2014 at 12:39:06AM +0200, Peter Lieven wrote: +static void iscsi_attach_aio_context(BlockDriverState *bs, +

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-08 Thread ronnie sahlberg
On Thu, May 8, 2014 at 4:33 AM, Stefan Hajnoczi stefa...@redhat.com wrote: On Wed, May 07, 2014 at 04:09:27PM +0200, Peter Lieven wrote: On 07.05.2014 12:29, Paolo Bonzini wrote: Il 07/05/2014 12:07, Stefan Hajnoczi ha scritto: On Fri, May 02, 2014 at 12:39:06AM +0200, Peter Lieven wrote:

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-08 Thread Peter Lieven
Am 08.05.2014 16:52, schrieb ronnie sahlberg: On Thu, May 8, 2014 at 4:33 AM, Stefan Hajnoczi stefa...@redhat.com wrote: On Wed, May 07, 2014 at 04:09:27PM +0200, Peter Lieven wrote: On 07.05.2014 12:29, Paolo Bonzini wrote: Il 07/05/2014 12:07, Stefan Hajnoczi ha scritto: On Fri, May 02,

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-07 Thread Stefan Hajnoczi
On Fri, May 02, 2014 at 12:39:06AM +0200, Peter Lieven wrote: +static void iscsi_attach_aio_context(BlockDriverState *bs, + AioContext *new_context) +{ +IscsiLun *iscsilun = bs-opaque; + +iscsilun-aio_context = new_context; +

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-07 Thread Paolo Bonzini
Il 07/05/2014 12:07, Stefan Hajnoczi ha scritto: On Fri, May 02, 2014 at 12:39:06AM +0200, Peter Lieven wrote: +static void iscsi_attach_aio_context(BlockDriverState *bs, + AioContext *new_context) +{ +IscsiLun *iscsilun = bs-opaque; + +

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-07 Thread Peter Lieven
On 07.05.2014 12:29, Paolo Bonzini wrote: Il 07/05/2014 12:07, Stefan Hajnoczi ha scritto: On Fri, May 02, 2014 at 12:39:06AM +0200, Peter Lieven wrote: +static void iscsi_attach_aio_context(BlockDriverState *bs, + AioContext *new_context) +{ +IscsiLun

[Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Stefan Hajnoczi
Drop the assumption that we're using the main AioContext for Linux AIO. Convert qemu_aio_set_fd_handler() to aio_set_fd_handler() and timer_new_ms() to aio_timer_new(). The .bdrv_detach/attach_aio_context() interfaces also need to be implemented to move the fd and timer from the old to the new

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Peter Lieven
Am 01.05.2014 um 16:54 schrieb Stefan Hajnoczi stefa...@redhat.com: Drop the assumption that we're using the main AioContext for Linux AIO. Convert qemu_aio_set_fd_handler() to aio_set_fd_handler() and timer_new_ms() to aio_timer_new(). The .bdrv_detach/attach_aio_context() interfaces

Re: [Qemu-devel] [PATCH 08/22] iscsi: implement .bdrv_detach/attach_aio_context()

2014-05-01 Thread Peter Lieven
Stefan Hajnoczi wrote: Drop the assumption that we're using the main AioContext for Linux AIO. Convert qemu_aio_set_fd_handler() to aio_set_fd_handler() and timer_new_ms() to aio_timer_new(). The .bdrv_detach/attach_aio_context() interfaces also need to be implemented to move the fd and