Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-03-01 Thread Alberto Garcia
On Fri 01 Mar 2019 03:18:09 PM CET, Kevin Wolf wrote: > Hm, actually, do you even need the runtime_opts list? > > You use it in bdrv_reset_options_allowed() to iterate through each > option and then check whether it was present in the old set of > options, but not in the new set of options. > > In

Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-03-01 Thread Kevin Wolf
Am 01.03.2019 um 14:05 hat Alberto Garcia geschrieben: > On Fri 01 Mar 2019 01:56:42 PM CET, Kevin Wolf wrote: > >> >> >> diff --git a/include/block/block_int.h b/include/block/block_int.h > >> >> >> index fd0e88d17a..e680dda86b 100644 > >> >> >> --- a/include/block/block_int.h > >> >> >> +++

Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-03-01 Thread Alberto Garcia
On Fri 01 Mar 2019 01:56:42 PM CET, Kevin Wolf wrote: >> >> >> diff --git a/include/block/block_int.h b/include/block/block_int.h >> >> >> index fd0e88d17a..e680dda86b 100644 >> >> >> --- a/include/block/block_int.h >> >> >> +++ b/include/block/block_int.h >> >> >> @@ -345,6 +345,13 @@ struct

Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-03-01 Thread Kevin Wolf
Am 01.03.2019 um 13:42 hat Alberto Garcia geschrieben: > On Fri 01 Mar 2019 01:36:08 PM CET, Kevin Wolf wrote: > > Am 01.03.2019 um 13:12 hat Alberto Garcia geschrieben: > >> On Tue 12 Feb 2019 07:02:31 PM CET, Kevin Wolf wrote: > >> >> diff --git a/include/block/block_int.h

Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-03-01 Thread Alberto Garcia
On Fri 01 Mar 2019 01:36:08 PM CET, Kevin Wolf wrote: > Am 01.03.2019 um 13:12 hat Alberto Garcia geschrieben: >> On Tue 12 Feb 2019 07:02:31 PM CET, Kevin Wolf wrote: >> >> diff --git a/include/block/block_int.h b/include/block/block_int.h >> >> index fd0e88d17a..e680dda86b 100644 >> >> ---

Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-03-01 Thread Kevin Wolf
Am 01.03.2019 um 13:12 hat Alberto Garcia geschrieben: > On Tue 12 Feb 2019 07:02:31 PM CET, Kevin Wolf wrote: > >> diff --git a/include/block/block_int.h b/include/block/block_int.h > >> index fd0e88d17a..e680dda86b 100644 > >> --- a/include/block/block_int.h > >> +++ b/include/block/block_int.h

Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-03-01 Thread Alberto Garcia
On Tue 12 Feb 2019 07:02:31 PM CET, Kevin Wolf wrote: >> diff --git a/include/block/block_int.h b/include/block/block_int.h >> index fd0e88d17a..e680dda86b 100644 >> --- a/include/block/block_int.h >> +++ b/include/block/block_int.h >> @@ -345,6 +345,13 @@ struct BlockDriver { >> >> /* List

Re: [Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-02-12 Thread Kevin Wolf
Am 17.01.2019 um 16:34 hat Alberto Garcia geschrieben: > This patch adds two new fields to BlockDriver: > >- runtime_opts: list of runtime options for a particular block > driver. We'll use this list later to detect what options are > missing when we try to reopen a block device. >

[Qemu-devel] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver

2019-01-17 Thread Alberto Garcia
This patch adds two new fields to BlockDriver: - runtime_opts: list of runtime options for a particular block driver. We'll use this list later to detect what options are missing when we try to reopen a block device. - mutable_opts: names of the runtime options that can be reset