Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

Mriyam Tamuli writes: > Thanks a lot for the feedback. I will do as you suggested. I have two more > questions, though - > > 1. So after a patch is submitted, there will be a review in sometime by > someone? Is that how I will come to know if my changes are correct? To answer the first part fir

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

Mriyam Tamuli writes: > Can anyone please comment on this? Am I doing anything wrong here? It's best to wait a few days. Most QEMU hackers work 9-5 jobs so activity on the mailing list is fairly light over the weekend. > > On Sat, Mar 12, 2016 at 5:22 PM Mriyam Tamuli wrote: >> >> Signed-off-

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

Mriyam Tamuli writes: > Signed-off-by: Mriyam Tamuli While this is a good change you still need to ensure any corresponding free's are converted to g_free (and g_delete for g_new). > --- > block/iscsi.c | 2 +- > bsd-user/elfload.c | 12 ++-- > bsd-user/qemu.h| 2 +- > con

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

Am 12.03.2016 um 18:53 schrieb Mriyam Tamuli: > Thanks a lot for the feedback. I will do as you suggested. I have two > more questions, though - > > 1. So after a patch is submitted, there will be a review in sometime by > someone? Is that how I will come to know if my changes are correct? Yes, t

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

Thanks a lot for the feedback. I will do as you suggested. I have two more questions, though - 1. So after a patch is submitted, there will be a review in sometime by someone? Is that how I will come to know if my changes are correct? 2. If I split the patch into smaller parts and send to qemu-tr

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

Am 12.03.2016 um 12:51 schrieb Mriyam Tamuli: > Signed-off-by: Mriyam Tamuli > --- > block/iscsi.c | 2 +- > bsd-user/elfload.c | 12 ++-- > bsd-user/qemu.h| 2 +- > configure | 4 ++-- > disas/ia64.c | 2 +- > 5 files changed, 11 insertions(+), 11 deletions(-)

Re: [Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

Can anyone please comment on this? Am I doing anything wrong here? On Sat, Mar 12, 2016 at 5:22 PM Mriyam Tamuli wrote: > > Signed-off-by: Mriyam Tamuli > --- > block/iscsi.c | 2 +- > bsd-user/elfload.c | 12 ++-- > bsd-user/qemu.h| 2 +- > configure | 4 ++-- > di

[Qemu-devel] [PATCH 1/1] Converted malloc calls to g_malloc and g_new

Signed-off-by: Mriyam Tamuli --- block/iscsi.c | 2 +- bsd-user/elfload.c | 12 ++-- bsd-user/qemu.h| 2 +- configure | 4 ++-- disas/ia64.c | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 128ea79..2d