Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

2019-08-14 Thread Jiri Denemark
On Thu, Jul 18, 2019 at 16:45:37 +0300, Denis V. Lunev wrote: > There are the following flags available in libvirt inside cpu_map.xm > > > > > > > We have faced the problem that QEMU does not start once these flags are > present in the domain.xml. Libvirt should

Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

2019-07-19 Thread Paolo Bonzini
On 20/07/19 00:05, Eduardo Habkost wrote: >> Actually KVM does not mark it as supported: >> >> const u32 kvm_cpuid_7_0_ebx_x86_features = >> F(FSGSBASE) | F(BMI1) | F(HLE) | F(AVX2) | F(SMEP) | >> F(BMI2) | F(ERMS) | f_invpcid | F(RTM) | f_mpx | F(RDSEED) | >

Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

2019-07-19 Thread Eduardo Habkost
On Fri, Jul 19, 2019 at 11:44:57PM +0200, Paolo Bonzini wrote: > On 19/07/19 22:53, Eduardo Habkost wrote: > > This is one is named "cqm" on Linux (X86_FEATURE_CQM). I prefer > > to keep consistency with the name already in use by Linux than > > the one in libvirt that was never used. > > > > You

Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

2019-07-19 Thread Paolo Bonzini
On 19/07/19 22:53, Eduardo Habkost wrote: > This is one is named "cqm" on Linux (X86_FEATURE_CQM). I prefer > to keep consistency with the name already in use by Linux than > the one in libvirt that was never used. > > You can still add a "cmt" alias property if you think it would be > useful. A

Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

2019-07-19 Thread Eduardo Habkost
On Thu, Jul 18, 2019 at 04:45:37PM +0300, Denis V. Lunev wrote: > There are the following flags available in libvirt inside cpu_map.xm > > This is bit 18... > > > > > We have faced the problem that QEMU does not start once these flags are > present in the domain

Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

2019-07-19 Thread Denis V. Lunev
On 7/18/19 4:52 PM, Paolo Bonzini wrote: > On 18/07/19 15:45, Denis V. Lunev wrote: >> There are the following flags available in libvirt inside cpu_map.xm >> >> >> >> >> >> >> We have faced the problem that QEMU does not start once these flags are >> present in t

Re: [Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

2019-07-18 Thread Paolo Bonzini
On 18/07/19 15:45, Denis V. Lunev wrote: > There are the following flags available in libvirt inside cpu_map.xm > > > > > > > We have faced the problem that QEMU does not start once these flags are > present in the domain.xml. > > This patch just adds proper name

[Qemu-devel] [PATCH 1/1] x86: add CPU flags supported inside libvirt

2019-07-18 Thread Denis V. Lunev
There are the following flags available in libvirt inside cpu_map.xm We have faced the problem that QEMU does not start once these flags are present in the domain.xml. This patch just adds proper names into the map. Signed-off-by: Denis V. Lunev CC: Paolo Bonzi