Re: [Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit

2010-01-12 Thread Kevin Wolf
Am 11.01.2010 18:51, schrieb Christoph Hellwig: Check the whitelist as early as possible instead of continuing the setup, and move all the error handling code to the end of the function. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/block.c

Re: [Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit

2010-01-12 Thread Kevin Wolf
Am 12.01.2010 18:09, schrieb Christoph Hellwig: On Tue, Jan 12, 2010 at 05:04:00PM +0100, Kevin Wolf wrote: To keep the behaviour as previously you'd need to set at least bs-drv in the unlink_and_fail case, too. I have no clue why it's important to set it to NULL when bs isn't going to be used

[Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit

2010-01-11 Thread Christoph Hellwig
Check the whitelist as early as possible instead of continuing the setup, and move all the error handling code to the end of the function. Signed-off-by: Christoph Hellwig h...@lst.de Index: qemu/block.c === --- qemu.orig/block.c