Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2014-01-10 Thread Andreas Färber
Peter, Am 07.01.2014 14:05, schrieb Peter Crosthwaite: If you bring FPGAs into the game, SYSBUS itself is ultimately pluggable. All sysbus devices under the sun are therefore legitimately pluggable in target-microblaze. You'll have to expand on this statement. :) From what I understand from

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2014-01-10 Thread Peter Crosthwaite
Hi Andreas, On Fri, Jan 10, 2014 at 7:10 PM, Andreas Färber afaer...@suse.de wrote: Peter, Am 07.01.2014 14:05, schrieb Peter Crosthwaite: If you bring FPGAs into the game, SYSBUS itself is ultimately pluggable. All sysbus devices under the sun are therefore legitimately pluggable in

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2014-01-07 Thread Andreas Färber
Am 16.12.2013 10:33, schrieb Peter Maydell: Anyway, I don't actively object to this series. I just think Anthony's going in the wrong direction which is why I haven't been particularly eager to actively mark it as reviewed-by me either... Sorry for not taking the time to reply to these

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2014-01-07 Thread Peter Maydell
On 7 January 2014 12:33, Andreas Färber afaer...@suse.de wrote: Am 16.12.2013 10:33, schrieb Peter Maydell: Anyway, I don't actively object to this series. I just think Anthony's going in the wrong direction which is why I haven't been particularly eager to actively mark it as reviewed-by me

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2014-01-07 Thread Andreas Färber
Am 07.01.2014 13:43, schrieb Peter Maydell: On 7 January 2014 12:33, Andreas Färber afaer...@suse.de wrote: Am 16.12.2013 10:33, schrieb Peter Maydell: Anyway, I don't actively object to this series. I just think Anthony's going in the wrong direction which is why I haven't been particularly

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2014-01-07 Thread Peter Crosthwaite
On Tue, Jan 7, 2014 at 10:43 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 7 January 2014 12:33, Andreas Färber afaer...@suse.de wrote: Am 16.12.2013 10:33, schrieb Peter Maydell: Anyway, I don't actively object to this series. I just think Anthony's going in the wrong direction which

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2014-01-07 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 7 January 2014 12:33, Andreas Färber afaer...@suse.de wrote: Am 16.12.2013 10:33, schrieb Peter Maydell: Anyway, I don't actively object to this series. I just think Anthony's going in the wrong direction which is why I haven't been

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2014-01-07 Thread Paolo Bonzini
Il 07/01/2014 13:43, Peter Maydell ha scritto: Sure. I think the right way to do that is to only allow them to plug in devices that are truly pluggable (ie which are on some pluggable bus like PCI or USB), rather than this way round, which is trying to blacklist devices rather than whitelist

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2013-12-16 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 15 December 2013 20:55, Andreas Färber afaer...@suse.de wrote: Since you're mentioned by name, should I wait for you to review the three OMAP parts? There's nothing particularly omap-specific in them. The only OMAP-specific issue I can think

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2013-12-16 Thread Peter Maydell
On 16 December 2013 08:48, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: I kind of think this whole thing is backwards anyway: we should really say the user can only instantiate devices via command line or monitor that are specifically intended to

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2013-12-16 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 16 December 2013 08:48, Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: I kind of think this whole thing is backwards anyway: we should really say the user can only instantiate devices via command

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2013-12-15 Thread Andreas Färber
Peter, Am 29.11.2013 10:43, schrieb arm...@redhat.com: From: Markus Armbruster arm...@redhat.com Pointer properties can be set only by code, not by device_add. A device with a pointer property can work with device_add only when the property may remain null. This is the case for property

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2013-12-15 Thread Peter Maydell
On 15 December 2013 20:55, Andreas Färber afaer...@suse.de wrote: Since you're mentioned by name, should I wait for you to review the three OMAP parts? There's nothing particularly omap-specific in them. I kind of think this whole thing is backwards anyway: we should really say the user can

[Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2013-11-29 Thread armbru
From: Markus Armbruster arm...@redhat.com Pointer properties can be set only by code, not by device_add. A device with a pointer property can work with device_add only when the property may remain null. This is the case for property interrupt_vector of device etraxfs,pic. Add a comment there.

Re: [Qemu-devel] [PATCH 1/2] hw: cannot_instantiate_with_device_add_yet due to pointer props

2013-11-29 Thread Edgar E. Iglesias
On Fri, Nov 29, 2013 at 10:43:44AM +0100, arm...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Pointer properties can be set only by code, not by device_add. A device with a pointer property can work with device_add only when the property may remain null. This is the case