Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-19 Thread Michael S. Tsirkin
On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote: QEMU must only make sure that patching of the supported roms with supported devices work. I think that's what Anthony was saying too - make this depend on a qdev property and set it only in eepro100 for now. -- MST

[Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-19 Thread Stefan Weil
PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet controller family is a typical example which is implemented in hw/eepro100.c. It uses at least 3 different device ids, so

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-19 Thread Stefan Weil
Am 19.10.2010 10:37, schrieb Michael S. Tsirkin: On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote: QEMU must only make sure that patching of the supported roms with supported devices work. I think that's what Anthony was saying too - make this depend on a qdev property and set it

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-19 Thread Anthony Liguori
On 10/19/2010 04:15 PM, Stefan Weil wrote: Am 19.10.2010 10:37, schrieb Michael S. Tsirkin: On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote: QEMU must only make sure that patching of the supported roms with supported devices work. I think that's what Anthony was saying too - make

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-19 Thread Michael S. Tsirkin
On Tue, Oct 19, 2010 at 04:22:23PM -0500, Anthony Liguori wrote: On 10/19/2010 04:15 PM, Stefan Weil wrote: Am 19.10.2010 10:37, schrieb Michael S. Tsirkin: On Mon, Oct 18, 2010 at 09:11:55PM +0200, Stefan Weil wrote: QEMU must only make sure that patching of the supported roms with supported

[Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Stefan Weil
PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet controller family is a typical example which is implemented in hw/eepro100.c. It uses at least 3 different device ids, so

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Anthony Liguori
On 10/18/2010 12:55 PM, Stefan Weil wrote: PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet controller family is a typical example which is implemented in hw/eepro100.c.

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Anthony Liguori
On 10/18/2010 01:44 PM, Anthony Liguori wrote: On 10/18/2010 12:55 PM, Stefan Weil wrote: PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The i825xx ethernet controller family is a typical

Re: [Qemu-devel] [PATCH 1/2] pci: Automatically patch PCI vendor id and device id in PCI ROM

2010-10-18 Thread Stefan Weil
Am 18.10.2010 20:53, schrieb Anthony Liguori: On 10/18/2010 01:44 PM, Anthony Liguori wrote: On 10/18/2010 12:55 PM, Stefan Weil wrote: PCI devices with different vendor or device ids sometimes share the same rom code. Only the ids and the checksum differs in a boot rom for such devices. The