Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-09 Thread Viktor Mihajlovski
On 08.02.2018 22:41, Eduardo Habkost wrote: > On Thu, Feb 08, 2018 at 02:59:17PM -0600, Eric Blake wrote: >> On 02/08/2018 01:59 PM, Eduardo Habkost wrote: >>> On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: The query-cpus command has an extremely serious side effect: it

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Thu, Feb 08, 2018 at 02:59:17PM -0600, Eric Blake wrote: > On 02/08/2018 01:59 PM, Eduardo Habkost wrote: > > On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: > > > The query-cpus command has an extremely serious side effect: > > > it always interrupt all running vCPUs so that

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eric Blake
On 02/08/2018 01:59 PM, Eduardo Habkost wrote: On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: The query-cpus command has an extremely serious side effect: it always interrupt all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Eduardo Habkost
On Wed, Feb 07, 2018 at 12:50:13PM -0500, Luiz Capitulino wrote: > The query-cpus command has an extremely serious side effect: > it always interrupt all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads. And most of the

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Luiz Capitulino
On Thu, 8 Feb 2018 08:41:31 +0100 Viktor Mihajlovski wrote: > On 07.02.2018 18:50, Luiz Capitulino wrote: > > The query-cpus command has an extremely serious side effect: > > it always interrupt all running vCPUs so that they can run > > ioctl calls. This can cause a

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-08 Thread Viktor Mihajlovski
On 08.02.2018 08:41, Viktor Mihajlovski wrote: > On 07.02.2018 18:50, Luiz Capitulino wrote: >> The query-cpus command has an extremely serious side effect: >> it always interrupt all running vCPUs so that they can run >> ioctl calls. This can cause a huge performance degradation for >> some

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-07 Thread Viktor Mihajlovski
On 07.02.2018 18:50, Luiz Capitulino wrote: > The query-cpus command has an extremely serious side effect: > it always interrupt all running vCPUs so that they can run > ioctl calls. This can cause a huge performance degradation for > some workloads. And most of the information retrieved by the >

Re: [Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-07 Thread Eric Blake
On 02/07/2018 11:50 AM, Luiz Capitulino wrote: The query-cpus command has an extremely serious side effect: it always interrupt all running vCPUs so that they can run s/interrupt/interrupts/ ioctl calls. This can cause a huge performance degradation for some workloads. And most of the

[Qemu-devel] [PATCH 1/2] qmp: add query-cpus-fast

2018-02-07 Thread Luiz Capitulino
The query-cpus command has an extremely serious side effect: it always interrupt all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for some workloads. And most of the information retrieved by the ioctl calls are not even used by query-cpus. This