Re: [Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-05-23 Thread li guang
ping ... again. 在 2013-04-22一的 11:44 +0800,liguang写道: for helper_{lsl, lar, verr, verw}, there are common parts, so move them outside, and then call this new helper-helper function. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- target-i386/seg_helper.c | 179

Re: [Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-05-23 Thread Peter Maydell
On 23 May 2013 09:35, li guang lig.f...@cn.fujitsu.com wrote: ping ... again. misc_check_helper is still a terrible function name. -- PMM

Re: [Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-05-23 Thread li guang
在 2013-05-23四的 10:24 +0100,Peter Maydell写道: On 23 May 2013 09:35, li guang lig.f...@cn.fujitsu.com wrote: ping ... again. misc_check_helper is still a terrible function name. Oh, sorry, I ping the obsolete one, I've sent a v2 for your comment: v2: change misc_check_helper to

Re: [Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-04-30 Thread Peter Maydell
On 22 April 2013 04:44, liguang lig.f...@cn.fujitsu.com wrote: for helper_{lsl, lar, verr, verw}, there are common parts, so move them outside, and then call this new helper-helper function. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- target-i386/seg_helper.c | 179

Re: [Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-04-30 Thread li guang
在 2013-04-30二的 08:16 +0100,Peter Maydell写道: On 22 April 2013 04:44, liguang lig.f...@cn.fujitsu.com wrote: for helper_{lsl, lar, verr, verw}, there are common parts, so move them outside, and then call this new helper-helper function. Signed-off-by: liguang lig.f...@cn.fujitsu.com ---

Re: [Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-04-29 Thread li guang
ping ... 在 2013-04-22一的 11:44 +0800,liguang写道: for helper_{lsl, lar, verr, verw}, there are common parts, so move them outside, and then call this new helper-helper function. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- target-i386/seg_helper.c | 179

[Qemu-devel] [PATCH 1/2] target-i386/seg_helper: refactor 4 helper functions

2013-04-21 Thread liguang
for helper_{lsl, lar, verr, verw}, there are common parts, so move them outside, and then call this new helper-helper function. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- target-i386/seg_helper.c | 179 ++--- 1 files changed, 56 insertions(+), 123