Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-08-02 Thread Igor Mammedov
On 08/01/2012 04:00 PM, Andreas Färber wrote: Am 23.07.2012 15:22, schrieb Igor Mammedov: MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in

Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-08-01 Thread Andreas Färber
Am 23.07.2012 15:22, schrieb Igor Mammedov: MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in implementing MP initialization protocol in qemu.

[Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-07-23 Thread Igor Mammedov
MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in implementing MP initialization protocol in qemu. Thus first CPU is always marked as BSP. This

Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-07-12 Thread Gleb Natapov
On Tue, Jul 10, 2012 at 03:15:51PM +0200, Igor Mammedov wrote: /* pc.c */ -int cpu_is_bsp(CPUX86State *env); Why remove it instead of modifying it to check BSP bit in apic base? I think it will make the patch smaller and open code the check does not look nice. -- Gleb.

Re: [Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-07-12 Thread Igor Mammedov
On 07/12/2012 08:38 AM, Gleb Natapov wrote: On Tue, Jul 10, 2012 at 03:15:51PM +0200, Igor Mammedov wrote: /* pc.c */ -int cpu_is_bsp(CPUX86State *env); Why remove it instead of modifying it to check BSP bit in apic base? I think it will make the patch smaller and open code the check does

[Qemu-devel] [PATCH 1/2] target-i386: move cpu halted decision into x86_cpu_reset

2012-07-10 Thread Igor Mammedov
MP initialization protocol differs between cpu families, and for P6 and onward models it is up to CPU to decide if it will be BSP using this protocol, so try to model this. However there is no point in implementing MP initialization protocol in qemu. Thus first CPU is always marked as BSP. This