Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-10-08 Thread Peter Xu
On Mon, Oct 02, 2017 at 07:18:04PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > >> IOThread is a general framework that contains IO loop environment and a > >> real thread behind. It's also good

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 03:35:05PM +0100, Stefan Hajnoczi wrote: > On Fri, Sep 22, 2017 at 11:28:08AM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 12:26:16PM +0200, Paolo Bonzini wrote: > > > On 22/09/2017 12:20, Daniel P. Berrange wrote: > > > > On Fri, Sep 22, 2017 at 12:18:44PM

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Stefan Hajnoczi
On Fri, Sep 22, 2017 at 11:28:08AM +0100, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 12:26:16PM +0200, Paolo Bonzini wrote: > > On 22/09/2017 12:20, Daniel P. Berrange wrote: > > > On Fri, Sep 22, 2017 at 12:18:44PM +0200, Paolo Bonzini wrote: > > >> On 22/09/2017 12:16, Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 14:59, Fam Zheng wrote: > On Fri, 09/22 11:17, Daniel P. Berrange wrote: >> Sorry yes, my bad - its the iothread behind the monitor. I still think that >> is a detail worth keeping private in case we want to refactor how the >> monitor threading works later. > I agree. I convinced

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Fam Zheng
On Fri, 09/22 11:17, Daniel P. Berrange wrote: > Sorry yes, my bad - its the iothread behind the monitor. I still think that > is a detail worth keeping private in case we want to refactor how the > monitor threading works later. I agree. I convinced Peter to reuse IOThread just because we can,

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Peter Xu
On Fri, Sep 22, 2017 at 12:14:04PM +0200, Paolo Bonzini wrote: > On 22/09/2017 11:43, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 11:38:31AM +0200, Paolo Bonzini wrote: > >> On 22/09/2017 11:36, Daniel P. Berrange wrote: > >>> On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: >

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 12:26:16PM +0200, Paolo Bonzini wrote: > On 22/09/2017 12:20, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 12:18:44PM +0200, Paolo Bonzini wrote: > >> On 22/09/2017 12:16, Stefan Hajnoczi wrote: > >>> I suggest adding internal IOThreads alongside user-created

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 12:20, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 12:18:44PM +0200, Paolo Bonzini wrote: >> On 22/09/2017 12:16, Stefan Hajnoczi wrote: >>> I suggest adding internal IOThreads alongside user-created IOThreads >>> instead of hiding them. IOThread also needs a bool

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 12:18:44PM +0200, Paolo Bonzini wrote: > On 22/09/2017 12:16, Stefan Hajnoczi wrote: > > I suggest adding internal IOThreads alongside user-created IOThreads > > instead of hiding them. IOThread also needs a bool user_created field > > and a

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 12:16, Stefan Hajnoczi wrote: > I suggest adding internal IOThreads alongside user-created IOThreads > instead of hiding them. IOThread also needs a bool user_created field > and a UserCreatableClass->can_be_deleted() function: > > static bool

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Stefan Hajnoczi
On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > IOThread is a general framework that contains IO loop environment and a > real thread behind. It's also good to be used internally inside qemu. > Provide some helpers for it to create iothreads to be used internally. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 12:14:04PM +0200, Paolo Bonzini wrote: > On 22/09/2017 11:43, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 11:38:31AM +0200, Paolo Bonzini wrote: > >> On 22/09/2017 11:36, Daniel P. Berrange wrote: > >>> On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: >

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 11:43, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 11:38:31AM +0200, Paolo Bonzini wrote: >> On 22/09/2017 11:36, Daniel P. Berrange wrote: >>> On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote:

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 11:38:31AM +0200, Paolo Bonzini wrote: > On 22/09/2017 11:36, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: > >> On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: > >>> On Fri, Sep 22, 2017 at 04:56:10PM +0800,

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 11:36, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: >> On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: >>> On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: IOThread is a general framework that contains IO loop

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: > On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > > > IOThread is a general framework that contains IO loop environment and a > > > real thread behind.

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Peter Xu
On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > > IOThread is a general framework that contains IO loop environment and a > > real thread behind. It's also good to be used internally inside qemu. > > Provide some

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > IOThread is a general framework that contains IO loop environment and a > real thread behind. It's also good to be used internally inside qemu. > Provide some helpers for it to create iothreads to be used internally. > > Signed-off-by:

[Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Peter Xu
IOThread is a general framework that contains IO loop environment and a real thread behind. It's also good to be used internally inside qemu. Provide some helpers for it to create iothreads to be used internally. Signed-off-by: Peter Xu --- include/sysemu/iothread.h | 8