Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-14 Thread Cédric Le Goater
On 06/14/2018 05:46 AM, David Gibson wrote: > On Wed, Jun 13, 2018 at 09:24:12AM +0200, Cédric Le Goater wrote: >> On 06/13/2018 06:22 AM, David Gibson wrote: >>> On Tue, Jun 05, 2018 at 08:41:13AM +0200, Cédric Le Goater wrote: On 06/05/2018 05:34 AM, David Gibson wrote: > On Mon, May 28,

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-13 Thread David Gibson
On Wed, Jun 13, 2018 at 09:24:12AM +0200, Cédric Le Goater wrote: > On 06/13/2018 06:22 AM, David Gibson wrote: > > On Tue, Jun 05, 2018 at 08:41:13AM +0200, Cédric Le Goater wrote: > >> On 06/05/2018 05:34 AM, David Gibson wrote: > >>> On Mon, May 28, 2018 at 09:06:12AM +0200, Cédric Le Goater wro

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-13 Thread Cédric Le Goater
On 06/13/2018 06:22 AM, David Gibson wrote: > On Tue, Jun 05, 2018 at 08:41:13AM +0200, Cédric Le Goater wrote: >> On 06/05/2018 05:34 AM, David Gibson wrote: >>> On Mon, May 28, 2018 at 09:06:12AM +0200, Cédric Le Goater wrote: On 05/28/2018 08:17 AM, Thomas Huth wrote: > On 25.05.2018 16

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-12 Thread David Gibson
On Tue, Jun 05, 2018 at 08:41:13AM +0200, Cédric Le Goater wrote: > On 06/05/2018 05:34 AM, David Gibson wrote: > > On Mon, May 28, 2018 at 09:06:12AM +0200, Cédric Le Goater wrote: > >> On 05/28/2018 08:17 AM, Thomas Huth wrote: > >>> On 25.05.2018 16:02, Greg Kurz wrote: > On Fri, 18 May 201

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-04 Thread Cédric Le Goater
On 06/05/2018 05:34 AM, David Gibson wrote: > On Mon, May 28, 2018 at 09:06:12AM +0200, Cédric Le Goater wrote: >> On 05/28/2018 08:17 AM, Thomas Huth wrote: >>> On 25.05.2018 16:02, Greg Kurz wrote: On Fri, 18 May 2018 18:44:02 +0200 Cédric Le Goater wrote: > This IRQ number hi

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-04 Thread David Gibson
On Mon, May 28, 2018 at 09:06:12AM +0200, Cédric Le Goater wrote: > On 05/28/2018 08:17 AM, Thomas Huth wrote: > > On 25.05.2018 16:02, Greg Kurz wrote: > >> On Fri, 18 May 2018 18:44:02 +0200 > >> Cédric Le Goater wrote: > >> > >>> This IRQ number hint can possibly be used by the VIO devices if t

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-03 Thread Cédric Le Goater
>> The property is a public interface. Just because it's not used by >> libvirt does not mean that nobody is using it. So yes, please follow the >> rules and mark it as deprecated first for two release, before you really >> remove it. > > I don't see a section for 'Deprecated' properties in the qe

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-02 Thread Cédric Le Goater
On 05/28/2018 08:17 AM, Thomas Huth wrote: > On 25.05.2018 16:02, Greg Kurz wrote: >> On Fri, 18 May 2018 18:44:02 +0200 >> Cédric Le Goater wrote: >> >>> This IRQ number hint can possibly be used by the VIO devices if the >>> "irq" property is defined on the command line but it seems it is never

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-06-02 Thread Cédric Le Goater
On 05/18/2018 06:44 PM, Cédric Le Goater wrote: > This IRQ number hint can possibly be used by the VIO devices if the > "irq" property is defined on the command line but it seems it is never > the case. It is not used in libvirt for instance. So, let's remove it > to simplify future changes. > > N

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-05-28 Thread Cédric Le Goater
On 05/28/2018 08:17 AM, Thomas Huth wrote: > On 25.05.2018 16:02, Greg Kurz wrote: >> On Fri, 18 May 2018 18:44:02 +0200 >> Cédric Le Goater wrote: >> >>> This IRQ number hint can possibly be used by the VIO devices if the >>> "irq" property is defined on the command line but it seems it is never

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-05-27 Thread Thomas Huth
On 25.05.2018 16:02, Greg Kurz wrote: > On Fri, 18 May 2018 18:44:02 +0200 > Cédric Le Goater wrote: > >> This IRQ number hint can possibly be used by the VIO devices if the >> "irq" property is defined on the command line but it seems it is never >> the case. It is not used in libvirt for instan

Re: [Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-05-25 Thread Greg Kurz
On Fri, 18 May 2018 18:44:02 +0200 Cédric Le Goater wrote: > This IRQ number hint can possibly be used by the VIO devices if the > "irq" property is defined on the command line but it seems it is never > the case. It is not used in libvirt for instance. So, let's remove it > to simplify future ch

[Qemu-devel] [PATCH 1/4] spapr: remove irq_hint parameter from spapr_irq_alloc()

2018-05-18 Thread Cédric Le Goater
This IRQ number hint can possibly be used by the VIO devices if the "irq" property is defined on the command line but it seems it is never the case. It is not used in libvirt for instance. So, let's remove it to simplify future changes. Nevertheless, this is a compatibbility breakage that will be