Re: [Qemu-devel] [PATCH 1/4] wm8750: remove duplicate macro

2018-10-11 Thread maozy
On 10/11/18 6:39 PM, Philippe Mathieu-Daudé wrote: Hi Mao, On 11/10/2018 11:00, Mao Zhongyi wrote: The header file wm8750.h contains '#define TYPE_WM8750 "wm8750"' macro, but '#define CODEC "wm8750"' macro is redefined in wm8750.c, just remove the local CODEC macro and replace it with

Re: [Qemu-devel] [PATCH 1/4] wm8750: remove duplicate macro

2018-10-11 Thread Philippe Mathieu-Daudé
Hi Mao, On 11/10/2018 11:00, Mao Zhongyi wrote: > The header file wm8750.h contains '#define TYPE_WM8750 "wm8750"' > macro, but '#define CODEC "wm8750"' macro is redefined in wm8750.c, > just remove the local CODEC macro and replace it with TYPE_WM8750. > > Cc: Gerd Hoffmann > > Signed-off-by:

[Qemu-devel] [PATCH 1/4] wm8750: remove duplicate macro

2018-10-11 Thread Mao Zhongyi
The header file wm8750.h contains '#define TYPE_WM8750 "wm8750"' macro, but '#define CODEC "wm8750"' macro is redefined in wm8750.c, just remove the local CODEC macro and replace it with TYPE_WM8750. Cc: Gerd Hoffmann Signed-off-by: Mao Zhongyi --- hw/audio/wm8750.c | 18 -- 1