Re: [Qemu-devel] [PATCH 1/7] spapr: Clean up cpu realize/unrealize paths

2018-06-13 Thread David Gibson
On Wed, Jun 13, 2018 at 10:11:45AM +0200, Cédric Le Goater wrote: > On 06/13/2018 08:57 AM, David Gibson wrote: > > spapr_cpu_init() and spapr_cpu_destroy() are only called from the spapr > > cpu core realize/unrealize paths, and really can only be called from there. > > > > Those are all short fu

Re: [Qemu-devel] [PATCH 1/7] spapr: Clean up cpu realize/unrealize paths

2018-06-13 Thread Greg Kurz
On Wed, 13 Jun 2018 10:11:45 +0200 Cédric Le Goater wrote: > On 06/13/2018 08:57 AM, David Gibson wrote: > > spapr_cpu_init() and spapr_cpu_destroy() are only called from the spapr > > cpu core realize/unrealize paths, and really can only be called from there. > > > > Those are all short functio

Re: [Qemu-devel] [PATCH 1/7] spapr: Clean up cpu realize/unrealize paths

2018-06-13 Thread Greg Kurz
On Wed, 13 Jun 2018 16:57:01 +1000 David Gibson wrote: > spapr_cpu_init() and spapr_cpu_destroy() are only called from the spapr > cpu core realize/unrealize paths, and really can only be called from there. > > Those are all short functions, so fold the pairs together for simplicity. > While we'

Re: [Qemu-devel] [PATCH 1/7] spapr: Clean up cpu realize/unrealize paths

2018-06-13 Thread Cédric Le Goater
On 06/13/2018 08:57 AM, David Gibson wrote: > spapr_cpu_init() and spapr_cpu_destroy() are only called from the spapr > cpu core realize/unrealize paths, and really can only be called from there. > > Those are all short functions, so fold the pairs together for simplicity. > While we're there rena

[Qemu-devel] [PATCH 1/7] spapr: Clean up cpu realize/unrealize paths

2018-06-13 Thread David Gibson
spapr_cpu_init() and spapr_cpu_destroy() are only called from the spapr cpu core realize/unrealize paths, and really can only be called from there. Those are all short functions, so fold the pairs together for simplicity. While we're there rename some functions and change some parameter types for