Re: [Qemu-devel] [PATCH 1/8] block-migration: acquire AioContext as necessary

2016-02-19 Thread Paolo Bonzini
On 16/02/2016 08:17, Fam Zheng wrote: >> @@ -321,8 +339,9 @@ static int set_dirty_tracking(void) >> int ret; >> >> QSIMPLEQ_FOREACH(bmds, _mig_state.bmds_list, entry) { >> +/* Creating/dropping dirty bitmaps only requires the big QEMU lock. >> */ > > Why? I don't think it

Re: [Qemu-devel] [PATCH 1/8] block-migration: acquire AioContext as necessary

2016-02-18 Thread Michael S. Tsirkin
ping Paolo - were you going to address these questions? Or did I miss it? On Tue, Feb 16, 2016 at 03:17:11PM +0800, Fam Zheng wrote: > On Sun, 02/14 18:17, Paolo Bonzini wrote: > > This is needed because dataplane will run during block migration as well. > > > > The block device migration code

Re: [Qemu-devel] [PATCH 1/8] block-migration: acquire AioContext as necessary

2016-02-15 Thread Fam Zheng
On Sun, 02/14 18:17, Paolo Bonzini wrote: > This is needed because dataplane will run during block migration as well. > > The block device migration code is quite liberal in taking the iothread > mutex. For simplicity, keep it the same way, even though one could > actually choose between the BQL

[Qemu-devel] [PATCH 1/8] block-migration: acquire AioContext as necessary

2016-02-14 Thread Paolo Bonzini
This is needed because dataplane will run during block migration as well. The block device migration code is quite liberal in taking the iothread mutex. For simplicity, keep it the same way, even though one could actually choose between the BQL (for regular BlockDriverStates) and the AioContext