Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-28 Thread Wei Wang
On 03/28/2018 03:37 PM, Peter Xu wrote: On Wed, Mar 28, 2018 at 03:30:06PM +0800, Wei Wang wrote: On 03/27/2018 11:24 PM, Xiao Guangrong wrote: On 03/28/2018 11:01 AM, Wang, Wei W wrote: On Tuesday, March 13, 2018 3:58 PM, Xiao Guangrong wrote: As compression is a heavy work, do not do it in

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-28 Thread Peter Xu
On Wed, Mar 28, 2018 at 03:30:06PM +0800, Wei Wang wrote: > On 03/27/2018 11:24 PM, Xiao Guangrong wrote: > > > > > > On 03/28/2018 11:01 AM, Wang, Wei W wrote: > > > On Tuesday, March 13, 2018 3:58 PM, Xiao Guangrong wrote: > > > > > > > > As compression is a heavy work, do not do it in migrati

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-28 Thread Wei Wang
On 03/27/2018 11:24 PM, Xiao Guangrong wrote: On 03/28/2018 11:01 AM, Wang, Wei W wrote: On Tuesday, March 13, 2018 3:58 PM, Xiao Guangrong wrote: As compression is a heavy work, do not do it in migration thread, instead, we post it out as a normal page Signed-off-by: Xiao Guangrong H

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-27 Thread Xiao Guangrong
On 03/28/2018 11:01 AM, Wang, Wei W wrote: On Tuesday, March 13, 2018 3:58 PM, Xiao Guangrong wrote: As compression is a heavy work, do not do it in migration thread, instead, we post it out as a normal page Signed-off-by: Xiao Guangrong Hi Guangrong, Dave asked me to help review your p

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-27 Thread Wang, Wei W
On Tuesday, March 13, 2018 3:58 PM, Xiao Guangrong wrote: > > As compression is a heavy work, do not do it in migration thread, instead, we > post it out as a normal page > > Signed-off-by: Xiao Guangrong Hi Guangrong, Dave asked me to help review your patch, so I will just drop my 2 cents w

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-27 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 03/26/2018 05:02 PM, Peter Xu wrote: > > On Thu, Mar 22, 2018 at 07:38:07PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 03/21/2018 04:19 PM, Peter Xu wrote: > > > > On Fri, Mar 16, 2018 at 04:05:14PM +0800, Xiao Guangrong wrote:

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-27 Thread Peter Xu
On Mon, Mar 26, 2018 at 11:43:33PM +0800, Xiao Guangrong wrote: > > > On 03/26/2018 05:02 PM, Peter Xu wrote: > > On Thu, Mar 22, 2018 at 07:38:07PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 03/21/2018 04:19 PM, Peter Xu wrote: > > > > On Fri, Mar 16, 2018 at 04:05:14PM +0800, Xiao Guan

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-26 Thread Xiao Guangrong
On 03/26/2018 05:02 PM, Peter Xu wrote: On Thu, Mar 22, 2018 at 07:38:07PM +0800, Xiao Guangrong wrote: On 03/21/2018 04:19 PM, Peter Xu wrote: On Fri, Mar 16, 2018 at 04:05:14PM +0800, Xiao Guangrong wrote: Hi David, Thanks for your review. On 03/15/2018 06:25 PM, Dr. David Alan Gilber

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-26 Thread Peter Xu
On Thu, Mar 22, 2018 at 07:38:07PM +0800, Xiao Guangrong wrote: > > > On 03/21/2018 04:19 PM, Peter Xu wrote: > > On Fri, Mar 16, 2018 at 04:05:14PM +0800, Xiao Guangrong wrote: > > > > > > Hi David, > > > > > > Thanks for your review. > > > > > > On 03/15/2018 06:25 PM, Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-22 Thread Xiao Guangrong
On 03/21/2018 04:19 PM, Peter Xu wrote: On Fri, Mar 16, 2018 at 04:05:14PM +0800, Xiao Guangrong wrote: Hi David, Thanks for your review. On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: migration/ram.c | 32 Hi, Do you have some performance n

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-21 Thread Peter Xu
On Fri, Mar 16, 2018 at 04:05:14PM +0800, Xiao Guangrong wrote: > > Hi David, > > Thanks for your review. > > On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: > > > > migration/ram.c | 32 > > > > Hi, > >Do you have some performance numbers to show th

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-19 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > Hi David, > > Thanks for your review. > > On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: > > > > migration/ram.c | 32 > > > > Hi, > >Do you have some performance numbers to show this helps? We

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-16 Thread Xiao Guangrong
Hi David, Thanks for your review. On 03/15/2018 06:25 PM, Dr. David Alan Gilbert wrote: migration/ram.c | 32 Hi, Do you have some performance numbers to show this helps? Were those taken on a normal system or were they taken with one of the compression

Re: [Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-15 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > As compression is a heavy work, do not do it in migration thread, > instead, we post it out as a normal page > > Signed-off-by: Xiao Guangrong > --- > migration/ram.c | 32

[Qemu-devel] [PATCH 1/8] migration: stop compressing page in migration thread

2018-03-13 Thread guangrong . xiao
From: Xiao Guangrong As compression is a heavy work, do not do it in migration thread, instead, we post it out as a normal page Signed-off-by: Xiao Guangrong --- migration/ram.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/migration/ram