Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-09 Thread Peter Xu
On Wed, Mar 09, 2016 at 10:03:51PM +0100, Markus Armbruster wrote: > Kevin Wolf writes: > > I think it's unnecessary, but fine with me. I'm just trying to say that > > making it a fixed 128 byte array on the stack certainly doesn't improve > > anything. > > It trades a few

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-09 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.03.2016 um 14:23 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 09.03.2016 um 04:04 hat Eric Blake geschrieben: >> >> On 03/08/2016 07:57 PM, Peter Xu wrote: >> >> > On Tue, Mar 08, 2016 at 11:19:44AM +0100,

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-09 Thread Kevin Wolf
Am 09.03.2016 um 14:23 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 09.03.2016 um 04:04 hat Eric Blake geschrieben: > >> On 03/08/2016 07:57 PM, Peter Xu wrote: > >> > On Tue, Mar 08, 2016 at 11:19:44AM +0100, Kevin Wolf wrote: > >> >> Am 08.03.2016 um 09:22

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-09 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.03.2016 um 04:04 hat Eric Blake geschrieben: >> On 03/08/2016 07:57 PM, Peter Xu wrote: >> > On Tue, Mar 08, 2016 at 11:19:44AM +0100, Kevin Wolf wrote: >> >> Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: >> >>> Same arguments as for PATCH

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-09 Thread Kevin Wolf
Am 09.03.2016 um 04:04 hat Eric Blake geschrieben: > On 03/08/2016 07:57 PM, Peter Xu wrote: > > On Tue, Mar 08, 2016 at 11:19:44AM +0100, Kevin Wolf wrote: > >> Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: > >>> Same arguments as for PATCH 2, except here an argument on the maximum >

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Peter Xu
On Tue, Mar 08, 2016 at 08:04:50PM -0700, Eric Blake wrote: > On 03/08/2016 07:57 PM, Peter Xu wrote: > > diff --git a/qobject/qdict.c b/qobject/qdict.c > > index 9833bd0..dde99e0 100644 > > --- a/qobject/qdict.c > > +++ b/qobject/qdict.c > > @@ -704,17 +704,16 @@ int qdict_array_entries(QDict

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Eric Blake
On 03/08/2016 07:57 PM, Peter Xu wrote: > On Tue, Mar 08, 2016 at 11:19:44AM +0100, Kevin Wolf wrote: >> Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: >>> Same arguments as for PATCH 2, except here an argument on the maximum >>> length of subqdict would probably be easier. >> >> Yes,

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Peter Xu
On Tue, Mar 08, 2016 at 11:19:44AM +0100, Kevin Wolf wrote: > Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: > > Same arguments as for PATCH 2, except here an argument on the maximum > > length of subqdict would probably be easier. > > Yes, these are constant string literals in all

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Daniel P. Berrange
On Tue, Mar 08, 2016 at 05:30:31PM +0100, Kevin Wolf wrote: > Am 08.03.2016 um 17:21 hat Eric Blake geschrieben: > > On 03/08/2016 03:19 AM, Kevin Wolf wrote: > > > Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: > > >> Cc: Kevin, because he added the array in question. > > >> > > >>

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Eric Blake
On 03/08/2016 03:19 AM, Kevin Wolf wrote: > Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: >> Cc: Kevin, because he added the array in question. >> >> Peter Xu writes: >> >> Unrelated to your patch: I think we've pushed QDict use father than >> sensible. Encoding

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Kevin Wolf
Am 08.03.2016 um 17:21 hat Eric Blake geschrieben: > On 03/08/2016 03:19 AM, Kevin Wolf wrote: > > Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: > >> Cc: Kevin, because he added the array in question. > >> > >> Peter Xu writes: > >> > > >> Unrelated to your patch:

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Kevin Wolf
Am 08.03.2016 um 09:22 hat Markus Armbruster geschrieben: > Cc: Kevin, because he added the array in question. > > Peter Xu writes: > > > Suggested-by: Paolo Bonzini > > CC: Luiz Capitulino > > Signed-off-by: Peter Xu

Re: [Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-08 Thread Markus Armbruster
Cc: Kevin, because he added the array in question. Peter Xu writes: > Suggested-by: Paolo Bonzini > CC: Luiz Capitulino > Signed-off-by: Peter Xu > --- > qobject/qdict.c | 15 +-- > 1 file

[Qemu-devel] [PATCH 1/8] qdict: fix unbounded stack for qdict_array_entries

2016-03-07 Thread Peter Xu
Suggested-by: Paolo Bonzini CC: Luiz Capitulino Signed-off-by: Peter Xu --- qobject/qdict.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index