Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 06/08/2015 09:21 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 08/31/2015 06:21 PM, Eric Blake wrote: > On 06/08/2015 09:21 AM, Vladimir Sementsov-Ogievskiy wrote: >> From: Vladimir Sementsov-Ogievskiy >> >> Persistent dirty bitmaps will be saved into qcow2 files. It may be used >> as 'internal' bitmaps (for qcow2 drives) or as

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

About structs and constraints: == Optional Header == 64bit nb_dirty_bitmaps valid: 1 - 65536. I think here should not be 0, in this case dirty-bitmap-optional-header should not exist at all. Should it instead be 0 - 65536 64bit dirty_bitmaps_offset valid: any, but

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

About structs and constraints: Optional Header: 64bit nb_dirty_bitmaps valid: 1 - 65536. I think here should not be 0, in this case dirty-bitmap-optional-header should not exist at all. Should it instead be 0 - 65536 64bit dirty_bitmaps_offset valid: any, but dirty_bitmaps_offset %

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

Sorry, drop this if you, look at the new version of this litter On 24.08.2015 16:30, Vladimir Sementsov-Ogievskiy wrote: About structs and constraints: Optional Header: 64bit nb_dirty_bitmaps valid: 1 - 65536. I think here should not be 0, in this case dirty-bitmap-optional-header should

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 10.06.2015 18:34, Kevin Wolf wrote: Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

Am 11.06.2015 um 18:30 hat John Snow geschrieben: On 06/11/2015 06:25 AM, Vladimir Sementsov-Ogievskiy wrote: On 10.06.2015 18:34, Kevin Wolf wrote: Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: +=== Bitmap table === + +A directory of all bitmaps is stored in the

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On Thu, Jun 11, 2015 at 12:21:31PM -0400, John Snow wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/11/2015 09:03 AM, Stefan Hajnoczi wrote: On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 10.06.2015 16:24, Stefan Hajnoczi wrote: On

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 06/12/2015 06:28 AM, Stefan Hajnoczi wrote: On Thu, Jun 11, 2015 at 12:21:31PM -0400, John Snow wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/11/2015 09:03 AM, Stefan Hajnoczi wrote: On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: On

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 10.06.2015 16:00, Eric Blake wrote: On 06/10/2015 02:19 AM, Vladimir Sementsov-Ogievskiy wrote: +Dirty bitmaps is an optional header extension. It provides a possibility of +storing dirty bitmaps in qcow2 image. The fields are: + + 0 - 3: nb_dirty_bitmaps +

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 10.06.2015 16:24, Stefan Hajnoczi wrote: On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -166,6 +167,19 @@ the header extension data.

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 10.06.2015 18:34, Kevin Wolf wrote: Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 10.06.2015 16:24, Stefan Hajnoczi wrote: On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/11/2015 09:03 AM, Stefan Hajnoczi wrote: On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 10.06.2015 16:24, Stefan Hajnoczi wrote: On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 06/11/2015 06:25 AM, Vladimir Sementsov-Ogievskiy wrote: On 10.06.2015 18:34, Kevin Wolf wrote: Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2 files. It may

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives)

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 06/10/2015 02:19 AM, Vladimir Sementsov-Ogievskiy wrote: +Dirty bitmaps is an optional header extension. It provides a possibility of +storing dirty bitmaps in qcow2 image. The fields are: + + 0 - 3: nb_dirty_bitmaps + Number of dirty bitmaps contained in the

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 10.06.2015 11:19, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir Sementsov-Ogievskiy wrote: On 09.06.2015 20:03, Stefan Hajnoczi wrote: On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: @@ -166,6 +167,19 @@ the header extension data. Each entry look like this:

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives (there

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives (there may be

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On Mon, Jun 08, 2015 at 06:21:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives

[Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

From: Vladimir Sementsov-Ogievskiy vsement...@parallels.com Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives (there may be qcow2 file with zero disk size but with several dirty bitmaps for

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

On 01/13/2015 10:02 AM, Vladimir Sementsov-Ogievskiy wrote: Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives (there may be qcow2 file with zero disk size but with several dirty bitmaps for

[Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives (there may be qcow2 file with zero disk size but with several dirty bitmaps for other drives). Signed-off-by: Vladimir Sementsov-Ogievskiy