Re: [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock

2013-10-17 Thread Luiz Capitulino
On Wed, 16 Oct 2013 19:17:08 +0200 Paolo Bonzini wrote: > This lock does not protect anything that the BQL does not already > protect. Furthermore, with -nodefaults and no monitor, the mutex > is not initialized but monitor_protocol_event_queue is called > anyway, which causes a crash under ming

Re: [Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock

2013-10-16 Thread Daniel P. Berrange
On Wed, Oct 16, 2013 at 07:17:08PM +0200, Paolo Bonzini wrote: > This lock does not protect anything that the BQL does not already > protect. Furthermore, with -nodefaults and no monitor, the mutex > is not initialized but monitor_protocol_event_queue is called > anyway, which causes a crash under

[Qemu-devel] [PATCH 1.7] monitor: eliminate monitor_event_state_lock

2013-10-16 Thread Paolo Bonzini
This lock does not protect anything that the BQL does not already protect. Furthermore, with -nodefaults and no monitor, the mutex is not initialized but monitor_protocol_event_queue is called anyway, which causes a crash under mingw (and only works by luck. under Linux or other POSIX OSes). Repo