Re: [Qemu-devel] [PATCH 11/17] ppc: Initialize AMOR in PAPR mode

2016-03-19 Thread David Gibson 
On Mon, Mar 14, 2016 at 05:56:34PM +0100, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt 
> 
> Make sure we give the guest full authorization
> 
> Signed-off-by: Benjamin Herrenschmidt 

So my guess is that this is essential for 2.6 if the other patches
affecting AMOR/AMR go in, but not otherwise.  Is that correct?

> ---
>  target-ppc/translate_init.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 68abd847a251..c921d9f53984 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -8542,6 +8542,7 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu)
>  {
>  CPUPPCState *env = >env;
>  ppc_spr_t *lpcr = >spr_cb[SPR_LPCR];
> +ppc_spr_t *amor = >spr_cb[SPR_AMOR];
>  
>  /* PAPR always has exception vectors in RAM not ROM. To ensure this,
>   * MSR[IP] should never be set.
> @@ -8563,6 +8564,9 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu)
>   */
>  env->spr[SPR_LPCR] = lpcr->default_value;
>  
> +/* Set a full AMOR so guest can use the AMR as it sees fit */
> +env->spr[SPR_AMOR] = amor->default_value = 0xull;
> +
>  /* Tell KVM that we're in PAPR mode */
>  if (kvm_enabled()) {
>  kvmppc_set_papr(cpu);

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

Re: [Qemu-devel] [PATCH 11/17] ppc: Initialize AMOR in PAPR mode

2016-03-15 Thread David Gibson 
On Mon, Mar 14, 2016 at 05:56:34PM +0100, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt 
> 
> Make sure we give the guest full authorization
> 
> Signed-off-by: Benjamin Herrenschmidt 

Reviewed-by: David Gibson 

I'm guessing this one is a fix that belongs in 2.6, but I'm not
entirely certain.

> ---
>  target-ppc/translate_init.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 68abd847a251..c921d9f53984 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -8542,6 +8542,7 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu)
>  {
>  CPUPPCState *env = >env;
>  ppc_spr_t *lpcr = >spr_cb[SPR_LPCR];
> +ppc_spr_t *amor = >spr_cb[SPR_AMOR];
>  
>  /* PAPR always has exception vectors in RAM not ROM. To ensure this,
>   * MSR[IP] should never be set.
> @@ -8563,6 +8564,9 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu)
>   */
>  env->spr[SPR_LPCR] = lpcr->default_value;
>  
> +/* Set a full AMOR so guest can use the AMR as it sees fit */
> +env->spr[SPR_AMOR] = amor->default_value = 0xull;
> +
>  /* Tell KVM that we're in PAPR mode */
>  if (kvm_enabled()) {
>  kvmppc_set_papr(cpu);

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

Re: [Qemu-devel] [PATCH 11/17] ppc: Initialize AMOR in PAPR mode

2016-03-14 Thread Thomas Huth 
On 14.03.2016 17:56, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt 
> 
> Make sure we give the guest full authorization
> 
> Signed-off-by: Benjamin Herrenschmidt 
> ---
>  target-ppc/translate_init.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 68abd847a251..c921d9f53984 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -8542,6 +8542,7 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu)
>  {
>  CPUPPCState *env = >env;
>  ppc_spr_t *lpcr = >spr_cb[SPR_LPCR];
> +ppc_spr_t *amor = >spr_cb[SPR_AMOR];
>  
>  /* PAPR always has exception vectors in RAM not ROM. To ensure this,
>   * MSR[IP] should never be set.
> @@ -8563,6 +8564,9 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu)
>   */
>  env->spr[SPR_LPCR] = lpcr->default_value;
>  
> +/* Set a full AMOR so guest can use the AMR as it sees fit */
> +env->spr[SPR_AMOR] = amor->default_value = 0xull;
> +
>  /* Tell KVM that we're in PAPR mode */
>  if (kvm_enabled()) {
>  kvmppc_set_papr(cpu);
> 

Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH 11/17] ppc: Initialize AMOR in PAPR mode

2016-03-14 Thread Cédric Le Goater 
From: Benjamin Herrenschmidt 

Make sure we give the guest full authorization

Signed-off-by: Benjamin Herrenschmidt 
---
 target-ppc/translate_init.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 68abd847a251..c921d9f53984 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -8542,6 +8542,7 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu)
 {
 CPUPPCState *env = >env;
 ppc_spr_t *lpcr = >spr_cb[SPR_LPCR];
+ppc_spr_t *amor = >spr_cb[SPR_AMOR];
 
 /* PAPR always has exception vectors in RAM not ROM. To ensure this,
  * MSR[IP] should never be set.
@@ -8563,6 +8564,9 @@ void cpu_ppc_set_papr(PowerPCCPU *cpu)
  */
 env->spr[SPR_LPCR] = lpcr->default_value;
 
+/* Set a full AMOR so guest can use the AMR as it sees fit */
+env->spr[SPR_AMOR] = amor->default_value = 0xull;
+
 /* Tell KVM that we're in PAPR mode */
 if (kvm_enabled()) {
 kvmppc_set_papr(cpu);
-- 
2.1.4