Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-21 Thread Eric Blake
On 10/21/2016 02:44 PM, Max Reitz wrote: >> Now I think I can drop this assignment, as bdrv_aligned_preadv have >> 'return ret < 0 ? ret : 0;' in the end... Am I right? Can bdrv_pwrite >> and friends return positive value on success? > > I think so, but if they do return positive value they're

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-21 Thread Max Reitz
On 17.10.2016 19:19, Vladimir Sementsov-Ogievskiy wrote: > On 07.10.2016 22:24, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Realize block bitmap stroing interface, to allow qcow2 images store >>> persistent bitmaps. >>> >>> Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-17 Thread Vladimir Sementsov-Ogievskiy
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Realize block bitmap stroing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 241

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-17 Thread Vladimir Sementsov-Ogievskiy
On 07.10.2016 22:24, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Realize block bitmap stroing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 241

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-15 Thread Max Reitz
On 13.10.2016 18:48, Vladimir Sementsov-Ogievskiy wrote: > On 07.10.2016 22:24, Max Reitz wrote: >> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: >>> Realize block bitmap stroing interface, to allow qcow2 images store > > [snip] > >>> +uint64_t end = MIN(bm_size, sector +

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-13 Thread Vladimir Sementsov-Ogievskiy
On 07.10.2016 22:24, Max Reitz wrote: On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: Realize block bitmap stroing interface, to allow qcow2 images store [snip] +uint64_t end = MIN(bm_size, sector + dsc); +uint64_t write_size = +

Re: [Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-10-07 Thread Max Reitz
On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote: > Realize block bitmap stroing interface, to allow qcow2 images store > persistent bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 241 >

[Qemu-devel] [PATCH 11/22] qcow2-bitmap: add qcow2_store_persistent_bitmaps()

2016-09-30 Thread Vladimir Sementsov-Ogievskiy
Realize block bitmap stroing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 241 +++ block/qcow2.c| 2 + block/qcow2.h|