Re: [Qemu-devel] [PATCH 14/50] target-ppc: make cpu-qom.h not target specific

2016-05-17 Thread Paolo Bonzini
On 17/05/2016 13:19, Thomas Huth wrote: >> > +#if defined(TARGET_PPC64) >> > +#define POWERPC_MMU_64 0x0001 >> > +#define POWERPC_MMU_1TSEG0x0002 >> > +#define POWERPC_MMU_AMR 0x0004 >> > +/* 64 bits PowerPC MMU */ >> > +

Re: [Qemu-devel] [PATCH 14/50] target-ppc: make cpu-qom.h not target specific

2016-05-17 Thread Thomas Huth
On 16.05.2016 17:35, Paolo Bonzini wrote: > Make PowerPCCPU an opaque type within cpu-qom.h, and move all definitions > of private methods, as well as all type definitions that require knowledge > of the layout to cpu.h. Conversely, move all definitions needed to define > a class to cpu-qom.h.

[Qemu-devel] [PATCH 14/50] target-ppc: make cpu-qom.h not target specific

2016-05-16 Thread Paolo Bonzini
Make PowerPCCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. Conversely, move all definitions needed to define a class to cpu-qom.h. This helps making files independent of NEED_CPU_H

[Qemu-devel] [PATCH 14/50] target-ppc: make cpu-qom.h not target specific

2016-04-08 Thread Paolo Bonzini
Make PowerPCCPU an opaque type within cpu-qom.h, and move all definitions of private methods, as well as all type definitions that require knowledge of the layout to cpu.h. Conversely, move all definitions needed to define a class to cpu-qom.h. This helps making files independent of NEED_CPU_H