On Thu, Aug 29, 2013 at 03:37:50PM +0200, Laszlo Ersek wrote:
+static void dump_cmd_req(const VirtIOSCSIReq *req, uint32_t cdb_size)
+{
+const VirtIOSCSICmdReq *cr;
+char *cdb_hex;
+
+if (!trace_event_get_state(TRACE_VIRTIO_SCSI_DUMP_CMD_REQ)) {
+return;
+}
+cr
On 09/04/13 16:21, Stefan Hajnoczi wrote:
On Thu, Aug 29, 2013 at 03:37:50PM +0200, Laszlo Ersek wrote:
+static void dump_cmd_req(const VirtIOSCSIReq *req, uint32_t cdb_size)
+{
+const VirtIOSCSICmdReq *cr;
+char *cdb_hex;
+
+if
The events that log a hexdump of the cdb and the sense buffer are disabled
by default, because they require more processing than a simple trace_XXX()
function call.
Signed-off-by: Laszlo Ersek ler...@redhat.com
---
hw/scsi/virtio-scsi.c | 76 +++--
Il 29/08/2013 15:37, Laszlo Ersek ha scritto:
The events that log a hexdump of the cdb and the sense buffer are disabled
by default, because they require more processing than a simple trace_XXX()
function call.
Signed-off-by: Laszlo Ersek ler...@redhat.com
trace_event_get_state doesn't work
On 08/29/13 15:59, Paolo Bonzini wrote:
Il 29/08/2013 15:37, Laszlo Ersek ha scritto:
The events that log a hexdump of the cdb and the sense buffer are disabled
by default, because they require more processing than a simple trace_XXX()
function call.
Signed-off-by: Laszlo Ersek
Il 29/08/2013 16:18, Laszlo Ersek ha scritto:
On 08/29/13 15:59, Paolo Bonzini wrote:
Il 29/08/2013 15:37, Laszlo Ersek ha scritto:
The events that log a hexdump of the cdb and the sense buffer are disabled
by default, because they require more processing than a simple trace_XXX()
function
On 08/29/13 16:53, Paolo Bonzini wrote:
(c) The way I submitted the series, the events in question are disabled
in trace-events. Check out the functions themselves: they are
protected (ie. even the trace_event_get_state() calls are protected)
with preprocessing directives. I did it this way
Il 29/08/2013 17:35, Laszlo Ersek ha scritto:
On 08/29/13 16:53, Paolo Bonzini wrote:
I'll try to salvage the patch.
I won't bother next time. I wouldn't want you to waste your time on
salvaging the clearly broken patches that I submit.
WTF?
The patch is clearly a good thing, or I wouldn't
