Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-03-19 Thread Vladimir Sementsov-Ogievskiy
On 19.03.2019 19:44, Andrey Shinkevich wrote: > > > On 18/03/2019 17:42, Alberto Garcia wrote: >> On Tue 26 Feb 2019 05:39:41 PM CET, Andrey Shinkevich wrote: >>> On 26/02/2019 16:33, Alberto Garcia wrote: On Mon 25 Feb 2019 05:39:14 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> ---

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-03-19 Thread Andrey Shinkevich
On 18/03/2019 17:42, Alberto Garcia wrote: > On Tue 26 Feb 2019 05:39:41 PM CET, Andrey Shinkevich wrote: >> On 26/02/2019 16:33, Alberto Garcia wrote: >>> On Mon 25 Feb 2019 05:39:14 PM CET, Vladimir Sementsov-Ogievskiy wrote: > --- a/block/stream.c > +++ b/block/stream.c > @@

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-03-18 Thread Alberto Garcia
On Tue 26 Feb 2019 05:39:41 PM CET, Andrey Shinkevich wrote: > On 26/02/2019 16:33, Alberto Garcia wrote: >> On Mon 25 Feb 2019 05:39:14 PM CET, Vladimir Sementsov-Ogievskiy wrote: --- a/block/stream.c +++ b/block/stream.c @@ -259,6 +259,15 @@ void stream_start(const char *job_id,

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-03-12 Thread Andrey Shinkevich
On 08/03/2019 17:00, Alberto Garcia wrote: > On Thu 21 Feb 2019 04:26:39 PM CET, Andrey Shinkevich wrote: >> The block-stream job needs to own the base node as the limiter >> of the copy-on-read operation. So, the base node is included in >> the job node list (block_job_add_bdrv). >> Also, the

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-03-08 Thread Alberto Garcia
On Thu 21 Feb 2019 04:26:39 PM CET, Andrey Shinkevich wrote: > The block-stream job needs to own the base node as the limiter > of the copy-on-read operation. So, the base node is included in > the job node list (block_job_add_bdrv). > Also, the block-stream job would not allow the base node to go

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-02-26 Thread Andrey Shinkevich
On 26/02/2019 16:33, Alberto Garcia wrote: > On Mon 25 Feb 2019 05:39:14 PM CET, Vladimir Sementsov-Ogievskiy wrote: >>> --- a/block/stream.c >>> +++ b/block/stream.c >>> @@ -259,6 +259,15 @@ void stream_start(const char *job_id, BlockDriverState >>> *bs, >>>

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-02-26 Thread Alberto Garcia
On Mon 25 Feb 2019 05:39:14 PM CET, Vladimir Sementsov-Ogievskiy wrote: >> --- a/block/stream.c >> +++ b/block/stream.c >> @@ -259,6 +259,15 @@ void stream_start(const char *job_id, BlockDriverState >> *bs, >> _abort); >> } >> >> +if (base) { >> +

Re: [Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-02-25 Thread Vladimir Sementsov-Ogievskiy
21.02.2019 18:26, Andrey Shinkevich wrote: > The block-stream job needs to own the base node as the limiter > of the copy-on-read operation. So, the base node is included in > the job node list (block_job_add_bdrv). > Also, the block-stream job would not allow the base node to go > away due to the

[Qemu-devel] [PATCH 2/2] block-stream: include base into job node list

2019-02-21 Thread Andrey Shinkevich
The block-stream job needs to own the base node as the limiter of the copy-on-read operation. So, the base node is included in the job node list (block_job_add_bdrv). Also, the block-stream job would not allow the base node to go away due to the graph modification, e.g. when a filter node is