[Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

2011-10-25 Thread Marc-André Lureau
Windows 7 may use the same stream number for input and output. Current code will confuse streams. Changes since v1: - keep running_compat[] for migration version 1 - add running_real[] for migration version 2 Signed-off-by: Marc-André Lureau --- hw/hda-audio.c | 26 +++---

[Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

2011-10-17 Thread Marc-André Lureau
Windows 7 may use the same stream number for input and output. Current code will confuse streams. Changes since v1: - keep running_compat[] for migration version 1 - add running_real[] for migration version 2 Signed-off-by: Marc-André Lureau --- hw/hda-audio.c | 26 +++---

Re: [Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

2011-10-14 Thread Gerd Hoffmann
Hi, a) My understanding of this patch is that we move from an array of 16 bools representing anything to one array where the 1st 16 represent if there are input and the 2nd 16's reprosenting if there are output for that channel. Correct. So, what we should do if we migrate from one old ver

Re: [Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

2011-10-04 Thread Marc-André Lureau
Hi On Tue, Oct 4, 2011 at 7:21 PM, Juan Quintela wrote: > "Marc-André Lureau" wrote: >> Windows 7 may use the same stream number for input and output. >> Current code will confuse streams. >> >> NB: I wonder if this patch breaks migration code because of >> this change: >> -        VMSTATE_BOOL_

Re: [Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

2011-10-04 Thread Juan Quintela
"Marc-André Lureau" wrote: > Windows 7 may use the same stream number for input and output. > Current code will confuse streams. > > NB: I wonder if this patch breaks migration code because of > this change: > -VMSTATE_BOOL_ARRAY(running, HDAAudioState, 16), > +VMSTATE_BOOL_ARRAY(r

[Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

2011-10-04 Thread Marc-André Lureau
Windows 7 may use the same stream number for input and output. Current code will confuse streams. NB: I wonder if this patch breaks migration code because of this change: -VMSTATE_BOOL_ARRAY(running, HDAAudioState, 16), +VMSTATE_BOOL_ARRAY(running, HDAAudioState, 2 * 16), --- hw/h