Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-10-07 Thread Gerd Hoffmann
On Fr, 2013-10-04 at 15:20 +0200, Igor Mammedov wrote: > On Wed, 21 Aug 2013 13:01:32 +0200 > Gerd Hoffmann wrote: > > > Hi, > > > > > +#define ICH9_PROC_BASE 0xaf00 > > > +#define ICH9_PROC_LEN 32 > > > > No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff > > I/O port w

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-10-04 Thread Igor Mammedov
On Wed, 21 Aug 2013 13:01:32 +0200 Gerd Hoffmann wrote: > Hi, > > > +#define ICH9_PROC_BASE 0xaf00 > > +#define ICH9_PROC_LEN 32 > > No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff > I/O port window to a PCI bridge. Please lets stop occupy random io > ports above 0x1

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-09-12 Thread Igor Mammedov
On Wed, 21 Aug 2013 17:04:28 +0800 Hu Tao wrote: > > Signed-off-by: Hu Tao > --- > hw/acpi/ich9.c | 91 > -- > include/hw/acpi/ich9.h | 11 ++ > 2 files changed, 100 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/ich9.c b/hw

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Andreas Färber
Am 21.08.2013 11:04, schrieb Hu Tao: > Signed-off-by: Hu Tao > --- > hw/acpi/ich9.c | 91 > -- > include/hw/acpi/ich9.h | 11 ++ > 2 files changed, 100 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > in

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Gerd Hoffmann
On Mi, 2013-08-21 at 13:27 +0200, Paolo Bonzini wrote: > Il 21/08/2013 13:01, Gerd Hoffmann ha scritto: > > Hi, > > > >> +#define ICH9_PROC_BASE 0xaf00 > >> +#define ICH9_PROC_LEN 32 > > > > No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff > > I/O port window to a PCI br

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 13:01, Gerd Hoffmann ha scritto: > Hi, > >> +#define ICH9_PROC_BASE 0xaf00 >> +#define ICH9_PROC_LEN 32 > > No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff > I/O port window to a PCI bridge. Please lets stop occupy random io > ports above 0x1000 and burn

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Gerd Hoffmann
Hi, > +#define ICH9_PROC_BASE 0xaf00 > +#define ICH9_PROC_LEN 32 No, please don't. It makes it impossible to assign the 0xa000 -> 0xafff I/O port window to a PCI bridge. Please lets stop occupy random io ports above 0x1000 and burn I/O address space that way. I'd suggest to place it at 0x0a0

Re: [Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Hu Tao
Added: Igor Mammedov On Wed, Aug 21, 2013 at 05:04:28PM +0800, Hu Tao wrote: > > Signed-off-by: Hu Tao > --- > hw/acpi/ich9.c | 91 > -- > include/hw/acpi/ich9.h | 11 ++ > 2 files changed, 100 insertions(+), 2 deletions(-) Hi Igor,

[Qemu-devel] [PATCH 2/2] q35: add cpu hotplug support

2013-08-21 Thread Hu Tao
Signed-off-by: Hu Tao --- hw/acpi/ich9.c | 91 -- include/hw/acpi/ich9.h | 11 ++ 2 files changed, 100 insertions(+), 2 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 8717c15..146216a 100644 --- a/hw/acpi/ich9.c +++ b/