Re: [Qemu-devel] [PATCH 2/2] target/openrisc: convert to TranslatorOps

2018-02-21 Thread Richard Henderson
On 02/17/2018 05:32 PM, Emilio G. Cota wrote: > +dc->next_page_start = (dc->base.pc_first & TARGET_PAGE_MASK) + > +TARGET_PAGE_SIZE; > +return max_insns; OpenRISC is standard 4-byte risc insn; should use the same bound mechanism as ppc and sparc. r~

Re: [Qemu-devel] [PATCH 2/2] target/openrisc: convert to TranslatorOps

2018-02-17 Thread Stafford Horne
On Sat, Feb 17, 2018 at 08:32:37PM -0500, Emilio G. Cota wrote: > Notes: > > - Changed the num_insns test in tb_start to check for > dc->base.num_insns > 1, since when tb_start is first > called in a TB, base.num_insns is already set to 1. > > - Removed DISAS_NEXT from the switch on tb_stop;

[Qemu-devel] [PATCH 2/2] target/openrisc: convert to TranslatorOps

2018-02-17 Thread Emilio G. Cota
Notes: - Changed the num_insns test in tb_start to check for dc->base.num_insns > 1, since when tb_start is first called in a TB, base.num_insns is already set to 1. - Removed DISAS_NEXT from the switch on tb_stop; use DISAS_TOO_MANY instead. - Added an assert_not_reached on tb_stop for