Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

2017-09-25 Thread Daniel Loffgren
> On Sep 25, 2017, at 9:10 AM, Eric Blake wrote: > > On 09/24/2017 08:02 PM, Daniel Loffgren wrote: >> >> Signed-off-by: Daniel Loffgren > > >> --- >> include/exec/user/thunk.h | 1 + >> 1 file changed, 1 insertion(+) > >

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

2017-09-25 Thread Daniel Loffgren
I am attempting to get ppc-darwin-user in a good working state again, and this broke one of the .c files that included it. I figured this change should be made regardless of my branch, and would help reduce the size of my branch for future rebasing. > On Sep 25, 2017, at 9:37 AM, Thomas Huth

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

2017-09-25 Thread Thomas Huth
Did this cause any trouble? ... one of two sentences in the patch description would be nice, I think. Thomas On 25.09.2017 03:02, Daniel Loffgren wrote: > > Signed-off-by: Daniel Loffgren > --- > include/exec/user/thunk.h | 1 + > 1 file changed, 1 insertion(+) > >

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

2017-09-25 Thread Eric Blake
On 09/24/2017 08:02 PM, Daniel Loffgren wrote: > > Signed-off-by: Daniel Loffgren > --- > include/exec/user/thunk.h | 1 + > 1 file changed, 1 insertion(+) meta-comment: your patch is titled 2/2, but was sent as its own top-level thread (it is missing In-Reply-To: and

[Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

2017-09-25 Thread Daniel Loffgren
Signed-off-by: Daniel Loffgren --- include/exec/user/thunk.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h index f19ef4b230..12b5449d8c 100644 --- a/include/exec/user/thunk.h +++ b/include/exec/user/thunk.h @@