Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect()

2016-07-22 Thread Cao jin
On 07/22/2016 06:38 PM, Daniel P. Berrange wrote: On Fri, Jul 22, 2016 at 06:43:51PM +0800, Cao jin wrote: On 07/22/2016 06:30 PM, Daniel P. Berrange wrote: On Fri, Jul 22, 2016 at 06:34:11PM +0800, Cao jin wrote: Hi Daniel On 07/21/2016 11:39 PM, Daniel P. Berrange wrote: On Thu, Jul

Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect()

2016-07-22 Thread Daniel P. Berrange
On Fri, Jul 22, 2016 at 06:43:51PM +0800, Cao jin wrote: > > > On 07/22/2016 06:30 PM, Daniel P. Berrange wrote: > > On Fri, Jul 22, 2016 at 06:34:11PM +0800, Cao jin wrote: > > > Hi Daniel > > > > > > On 07/21/2016 11:39 PM, Daniel P. Berrange wrote: > > > > On Thu, Jul 21, 2016 at 08:42:25AM

Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect()

2016-07-22 Thread Cao jin
On 07/22/2016 06:30 PM, Daniel P. Berrange wrote: On Fri, Jul 22, 2016 at 06:34:11PM +0800, Cao jin wrote: Hi Daniel On 07/21/2016 11:39 PM, Daniel P. Berrange wrote: On Thu, Jul 21, 2016 at 08:42:25AM -0600, Eric Blake wrote: On 07/21/2016 04:33 AM, Cao jin wrote: It is never used, and

Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect()

2016-07-22 Thread Daniel P. Berrange
On Fri, Jul 22, 2016 at 06:34:11PM +0800, Cao jin wrote: > Hi Daniel > > On 07/21/2016 11:39 PM, Daniel P. Berrange wrote: > > On Thu, Jul 21, 2016 at 08:42:25AM -0600, Eric Blake wrote: > > > On 07/21/2016 04:33 AM, Cao jin wrote: > > > > It is never used, and now all connect is nonblocking via

Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect()

2016-07-22 Thread Cao jin
Hi Daniel On 07/21/2016 11:39 PM, Daniel P. Berrange wrote: On Thu, Jul 21, 2016 at 08:42:25AM -0600, Eric Blake wrote: On 07/21/2016 04:33 AM, Cao jin wrote: It is never used, and now all connect is nonblocking via inet_connect_addr(). Could be squashed with 1/2. In fact, if you squash

Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect()

2016-07-21 Thread Daniel P. Berrange
On Thu, Jul 21, 2016 at 08:42:25AM -0600, Eric Blake wrote: > On 07/21/2016 04:33 AM, Cao jin wrote: > > It is never used, and now all connect is nonblocking via > > inet_connect_addr(). > > > > Could be squashed with 1/2. In fact, if you squash it, I'd title the patch: > > util: Drop unused

Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect()

2016-07-21 Thread Eric Blake
On 07/21/2016 04:33 AM, Cao jin wrote: > It is never used, and now all connect is nonblocking via > inet_connect_addr(). > Could be squashed with 1/2. In fact, if you squash it, I'd title the patch: util: Drop unused *_nonblocking_connect() functions You may also want to call out which commit

[Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect()

2016-07-21 Thread Cao jin
It is never used, and now all connect is nonblocking via inet_connect_addr(). Cc: Daniel P. Berrange Cc: Gerd Hoffmann Cc: Paolo Bonzini Signed-off-by: Cao jin --- include/qemu/sockets.h | 3 ---