Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Markus Armbruster
Wei Yang writes: > On Tue, Apr 02, 2019 at 06:10:23PM +0200, Markus Armbruster wrote: >>Wei Yang writes: > > [...] > > > @@ -2659,7 +2655,8 @@ static const QEMUOption *lookup_opt(int argc, char > **argv, > > static MachineClass *select_machine(void) > { > -

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Wei Yang
On Tue, Apr 02, 2019 at 06:10:23PM +0200, Markus Armbruster wrote: >Wei Yang writes: [...] @@ -2659,7 +2655,8 @@ static const QEMUOption *lookup_opt(int argc, char **argv, static MachineClass *select_machine(void) { -MachineClass *machine_class = fin

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Markus Armbruster
Wei Yang writes: > On Tue, Apr 02, 2019 at 03:28:48PM +0200, Markus Armbruster wrote: >>Wei Yang writes: >> >>> Now all the functions used to select machine is local and the call flow >>> looks like below: >>> >>> select_machine() >>> find_default_machine() >>> machine_parse(

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Wei Yang
On Tue, Apr 02, 2019 at 03:28:48PM +0200, Markus Armbruster wrote: >Wei Yang writes: > >> Now all the functions used to select machine is local and the call flow >> looks like below: >> >> select_machine() >> find_default_machine() >> machine_parse() >> find_machine

Re: [Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-04-02 Thread Markus Armbruster
Wei Yang writes: > Now all the functions used to select machine is local and the call flow > looks like below: > > select_machine() > find_default_machine() > machine_parse() > find_machine() > > All these related function will need a GSList for TYPE_MACHINE. > Cur

[Qemu-devel] [PATCH 2/2] vl.c: allocate TYPE_MACHINE list once during bootup

2019-03-10 Thread Wei Yang
Now all the functions used to select machine is local and the call flow looks like below: select_machine() find_default_machine() machine_parse() find_machine() All these related function will need a GSList for TYPE_MACHINE. Currently we allocate this list each tim