Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI

2017-07-31 Thread Markus Armbruster
Eric Blake writes: > On 07/28/2017 12:17 PM, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >>> COLOMode is defined in the QAPI schema, but not used there. Of the >>> stuff QAPI generates for it only the typedef is actually used. Use of >>>

Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI

2017-07-29 Thread Hailiang Zhang
On 2017/7/29 1:17, Dr. David Alan Gilbert wrote: * Markus Armbruster (arm...@redhat.com) wrote: COLOMode is defined in the QAPI schema, but not used there. Of the stuff QAPI generates for it only the typedef is actually used. Use of QAPI is pointless and only complicates things, so don't.

Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI

2017-07-28 Thread Eric Blake
On 07/28/2017 12:17 PM, Dr. David Alan Gilbert wrote: > * Markus Armbruster (arm...@redhat.com) wrote: >> COLOMode is defined in the QAPI schema, but not used there. Of the >> stuff QAPI generates for it only the typedef is actually used. Use of >> QAPI is pointless and only complicates things,

Re: [Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI

2017-07-28 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > COLOMode is defined in the QAPI schema, but not used there. Of the > stuff QAPI generates for it only the typedef is actually used. Use of > QAPI is pointless and only complicates things, so don't. Hmm, in one of the old COLO worlds I have,

[Qemu-devel] [PATCH 2/3] COLO: Define COLOMode without QAPI

2017-07-28 Thread Markus Armbruster
COLOMode is defined in the QAPI schema, but not used there. Of the stuff QAPI generates for it only the typedef is actually used. Use of QAPI is pointless and only complicates things, so don't. Cc: zhanghailiang Signed-off-by: Markus Armbruster