Re: [Qemu-devel] [PATCH 2/3] fw_cfg: add API to find FW cfg object

2013-05-30 Thread Hu Tao
On Thu, May 30, 2013 at 04:28:01PM +0300, Michael S. Tsirkin wrote: > Remove some code duplication by adding a > function to look up the fw cfg file. > This way, we don't need to duplicate same strings everywhere. > Use by both fw cfg and pvpanic device. > > Signed-off-by: Michael S. Tsirkin > --

Re: [Qemu-devel] [PATCH 2/3] fw_cfg: add API to find FW cfg object

2013-05-30 Thread Laszlo Ersek
On 05/30/13 15:28, Michael S. Tsirkin wrote: > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > index 1483f27..910e44f 100644 > --- a/hw/misc/pvpanic.c > +++ b/hw/misc/pvpanic.c > @@ -96,7 +96,7 @@ static int pvpanic_isa_initfn(ISADevice *dev) > isa_register_ioport(dev, &s->io, s->ioport)

[Qemu-devel] [PATCH 2/3] fw_cfg: add API to find FW cfg object

2013-05-30 Thread Michael S. Tsirkin
Remove some code duplication by adding a function to look up the fw cfg file. This way, we don't need to duplicate same strings everywhere. Use by both fw cfg and pvpanic device. Signed-off-by: Michael S. Tsirkin --- hw/misc/pvpanic.c | 2 +- hw/nvram/fw_cfg.c | 15 -