Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-06-05 Thread Thomas Huth
On 01.06.2018 22:19, Farhan Ali wrote: > > > On 05/31/2018 11:21 PM, Thomas Huth wrote: >>> Just a question do we want to clear cfgbuf here, before calling >>> pxelinux_load_parse_cfg? >> That's theoretically not necessary. The buffer either gets populated >> with data, or the function errors

Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-06-01 Thread Farhan Ali
On 05/31/2018 11:21 PM, Thomas Huth wrote: Just a question do we want to clear cfgbuf here, before calling pxelinux_load_parse_cfg? That's theoretically not necessary. The buffer either gets populated with data, or the function errors out. The code also makes sure that there is a final

Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-05-31 Thread Thomas Huth
On 30.05.2018 13:07, Viktor VM Mihajlovski wrote: > On 30.05.2018 11:16, Thomas Huth wrote: >> Since it is quite cumbersome to manually create a combined kernel with >> initrd image for network booting, we now support loading via pxelinux >> configuration files, too. In these files, the kernel,

Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-05-31 Thread Thomas Huth
On 31.05.2018 23:25, Farhan Ali wrote: > > > On 05/30/2018 05:16 AM, Thomas Huth wrote: >> Since it is quite cumbersome to manually create a combined kernel with >> initrd image for network booting, we now support loading via pxelinux >> configuration files, too. In these files, the kernel,

Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-05-31 Thread Farhan Ali
On 05/30/2018 05:16 AM, Thomas Huth wrote: Since it is quite cumbersome to manually create a combined kernel with initrd image for network booting, we now support loading via pxelinux configuration files, too. In these files, the kernel, initrd and command line parameters can be specified

Re: [Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-05-30 Thread Viktor VM Mihajlovski
On 30.05.2018 11:16, Thomas Huth wrote: > Since it is quite cumbersome to manually create a combined kernel with > initrd image for network booting, we now support loading via pxelinux > configuration files, too. In these files, the kernel, initrd and command > line parameters can be specified

[Qemu-devel] [PATCH 2/3] pc-bios/s390-ccw/net: Add support for pxelinux-style config files

2018-05-30 Thread Thomas Huth
Since it is quite cumbersome to manually create a combined kernel with initrd image for network booting, we now support loading via pxelinux configuration files, too. In these files, the kernel, initrd and command line parameters can be specified seperately, and the firmware then takes care of